Community
Participate
Working Groups
See bug 207498: [patch] stop automatic configuration retrieval if already done https://bugs.eclipse.org/bugs/show_bug.cgi?id=207498#c10 What you want is a new bug: Task, Category and Repository should fill the standard Properties view: http://dev.eclipse.org/blogs/wayne/2007/10/08/getting-started-with-properties/ http://dev.eclipse.org/blogs/wayne/2007/10/15/adapters/ http://dev.eclipse.org/blogs/wayne/2007/10/23/adapters-part-deux/ Some key data relevant to users (or developers) can be shown here
Please don't use that fancy bloated property pages that have tabs. Good old tree table is the best.
Steps: Make sure that the Task List tells the Properties View of selection changes add a getAdapter() to AbstractTaskContainer, AbstratRepositoryQuery, AbstractTaskCartegory, AbstractTask, TaskRepository add IPropertySource implementations for each in org.eclipse.mylyn.tasks.ui Anything else?
Maarten: could you outline the use cases for this?
My original idea was to make some spies as tools for connector developers to help display inside information, I already have a repository spy see bug 207498. Eugene suggested using the properties view. I use Properties View if I want to know more about a file/resource/ui element than is shown in the list (or hover), but less than actually opening the editor. I think I need to give it a good think and do a simple one on the Task Repositories view.
My understanding is that IPropertiesSourceObjects could be contributed by external plug-ins. This could be indeed be useful for inspection of query, task and repository objects during testing. This wouldn't have to be released but could be available from the sandbox in CVS only.
+1 for this being a Sandbox contribution for debugging For knowing more about tasks without opening the editor Steffen will be improving the tooltips (bug 205861).
Created attachment 82136 [details] mylyn/context/zip Some new calsses in the spy project
Created attachment 82137 [details] bugzilla task properties view
Created attachment 82138 [details] local task properties view Any more properties needed?
Created attachment 82139 [details] repository query properties view
Created attachment 82141 [details] task repository properties view
- How deep and specific should the adapters be, just the main classes or special as well for bugzilla, jira and trac... - should properties be editable? All this in addition to a repository spy that can also DELETE properties
That looks very useful. Maarten, could you post a patch with your current implementation? I think generic implementations that work on the abstract classes suffice for now unless a driver comes up to extend the implementation to connector specific classes.
Created attachment 82169 [details] org.eclipse.mylyn.tasks.spy Patch don't work when not shared project :-( I have created a new project: org.eclipse.mylyn.tasks.spy which contains the IPropertySource adapters for AbstractTaks, TaskRepository, RepositoryQuery and TaskCategory plus MylynPropertiesSourceFactory to create them. There is startup code to register the factory and adapters on startup, so they work immediately. Also included is a Repository Spy view where you can also DELETE properties.
Maarten: could you make your patch target a package in org.eclipse.mylyn.sandbox.dev instead of a full new project? We use that project for features of this sort.
Created attachment 82249 [details] Tasks properties & repository spy in mylyn.sandbox.dev As per Mik's request in comment 15
Please use the properties view on some elements to look at the text representation of dates that are used throughout Mylyn. Each and every one of them appears to use a different format :-( That is why I created and submitted TimestampUtils.java as part of my patch for bug 207498.
I think this is it
Patch applied. Great stuff Maarten! Should we now get rid of the IntrospectObjectACtion and inline some of what it does into the Properties pages? The only real functionality that will be missing is provided by the Plug-in Spy, which we can also contribute to if needed. After getting some mileage on this we can consider moving in to mylyn.tasks.ui, since it doesn't necessarily get in the way. But I still see the main use cases as developer and not end user oriented.
The main problem I see with moving it into tasks.ui is that some of the properties on TaskRepository are connector specific and it is not clear how to present them. This could end up being more confusing than helpful to a user. +1 for contributing to plug-in spy in favor of introspect actions
Agreed. Maarten: you added an early startup extension to the plug-in. I removed this because it's generally a problematic policy to start things eagerly. Also, it wasn't working because the plug-in did not implement IStartup. Also, I applied this patch in too much of a rush and should have given you more feedback on the Eclipse conventions that we adhere to for naming. I have updated the patch to these conventions, so please review them for future reference. Also note that I added the Repository Spy view to the Mylyn Sandbox category.
(In reply to comment #21) > Maarten: you added an early startup extension to the plug-in. I removed this > because it's generally a problematic policy to start things eagerly. Also, it > wasn't working because the plug-in did not implement IStartup. OK, your the lead ;-) My reason for adding it is I found that the properties weren't showing at first if the plugin wasn't started, as the factory wasn't started yet. So a click in any Mylyn view did not show anything in the properties view. I had to open the Repository Spy view to get the properties to work. BTW, Is there an update manager URL for the compiled sandbox feature?
(In reply to comment #22) > OK, your the lead ;-) This is unrelated to my being a lead, it's an Eclipse convention that we follow, and those are always up for debate if needed. My job as lead is to arbitrate when such debates come to a stalemate :) And to ensure consistency in our decisions and design aesthetics. > My reason for adding it is I found that the properties weren't showing at first > if the plugin wasn't started, as the factory wasn't started yet. So a click in > any Mylyn view did not show anything in the properties view. I had to open the > Repository Spy view to get the properties to work. Is this still the case? Note that it never would have worked because the plug-in did not implement IStartup, which is a requirement for early start. > BTW, Is there an update manager URL for the compiled sandbox feature? Yup, it's on the extras: http://www.eclipse.org/mylyn/downloads/
(In reply to comment #23) > > BTW, Is there an update manager URL for the compiled sandbox feature? > Yup, it's on the extras: http://www.eclipse.org/mylyn/downloads/ Mik probably meant "experimental" update site (not the same as "extras" update site), which can be found under "Archives and other builds" link from Mylyn download page. Direct url for that update site is http://download.eclipse.org/tools/mylyn/update/weekly/experimental
Yup, sorry, I did mean the Experimental site.
