Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 208047 - [prov] [ui] - not seeing restart/apply changes dialog on install/update
Summary: [prov] [ui] - not seeing restart/apply changes dialog on install/update
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Incubator (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P4 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 210668 (view as bug list)
Depends on: 208251
Blocks:
  Show dependency tree
 
Reported: 2007-10-30 12:51 EDT by Susan McCourt CLA
Modified: 2007-11-22 10:19 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2007-10-30 12:51:05 EDT 
- I generated metadata for 3.4 M2 and for I20071029-0800 in a local repo.
- I provisioned a 3.4M2 SDK + end user UI using the RCP agent from HEAD (due to
path problems in the donwloaded agent).
- This SDK starts up fine, end user UI is there, etc.
- I successfully added the releng tools (but was not prompted to restart/apply)
- I restarted the SDK manually
- I got the auto updates prompt and then saw that an update was available for
the SDK
- I tried to update to this version (from my local repo)
- It did a lot of work (progress only showed in the details of the progress
bar, not in the main progress bar)
- It seemed to complete successfully
- I was not prompted to restart
Comment 1 Pascal Rapicault CLA 2007-10-30 15:34:36 EDT 
Investigate
Comment 2 Susan McCourt CLA 2007-10-31 13:42:37 EDT 
The problem is a threading issue.  The restart dialog is trying to open in a non-UI thread and before it hits the standard threading exception, it tries to look up an image with a null display.

This could be fixed, but fixing it would open another can of worms given bug #208251, fixing it would likely cause a bunch of bogus restart dialogs to surface when sizing an install.  This could be fixed, but.....

...I think it's best to address this for M4.
Comment 3 Susan McCourt CLA 2007-11-20 18:25:38 EST 
I added a workaround for bug #208251 so this dialog is back now.
Comment 4 John Arthorne CLA 2007-11-22 10:19:33 EST 
*** Bug 210668 has been marked as a duplicate of this bug. ***