Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 207660 - do not update repository configuration on every startup
Summary: do not update repository configuration on every startup
Status: RESOLVED DUPLICATE of bug 207498
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 2.2   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-27 04:07 EDT by Steffen Pingel CLA
Modified: 2007-10-29 13:55 EDT (History)
1 user (show)

See Also:


Attachments
Maybe this is too simple (1.67 KB, patch)
2007-10-28 07:50 EDT, maarten meijer CLA
no flags Details | Diff
mylyn/context/zip (2.92 KB, application/octet-stream)
2007-10-28 07:51 EDT, maarten meijer CLA
no flags Details
Patch where last (global) config update date is stored in preferences (3.92 KB, patch)
2007-10-29 08:59 EDT, maarten meijer CLA
no flags Details | Diff
mylyn/context/zip (5.09 KB, application/octet-stream)
2007-10-29 08:59 EDT, maarten meijer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2007-10-27 04:07:38 EDT
Only update repository configuration every 24 hours.
Comment 1 maarten meijer CLA 2007-10-28 07:50:59 EDT
Created attachment 81337 [details]
Maybe this is too simple

synchronize on startup is a flag that can be set or unset. Changing true to false is the soluytion to this bug. Or is more functionality required?
Comment 2 maarten meijer CLA 2007-10-28 07:51:01 EDT
Created attachment 81338 [details]
mylyn/context/zip
Comment 3 maarten meijer CLA 2007-10-28 07:54:18 EDT
can't set the [patch] flag as not assigned to me :-(
Comment 4 maarten meijer CLA 2007-10-29 08:42:36 EDT
ScheduledTaskListSynchJob already checks to see that it updates the config only once a day.
Problem: On start up the date to check against is still null. This is a global, meaning all repositories are checked against the same date!
This seems ok as this is the default, one can always force a manual update of teh configuration!

Solution 1:
persist a single date that any config was last updated. This can be done in global preferences as the config is cached globally as well!

Solution 2:
persist the per repository date when that config was last updated. This can be done in persisting repository properties

Solution 3:
check against the file date of the cached config. This should be retrievable and comparable, but seems to low level

Solution 1 seems simplest and is therefor preferred.
Comment 5 maarten meijer CLA 2007-10-29 08:59:29 EDT
Created attachment 81441 [details]
Patch where last (global) config update date is stored in preferences

Should reallly be a per config date, but that is a lot more work
Comment 6 maarten meijer CLA 2007-10-29 08:59:31 EDT
Created attachment 81442 [details]
mylyn/context/zip
Comment 7 maarten meijer CLA 2007-10-29 09:00:32 EDT
Robert, can you assign to me?
Comment 8 maarten meijer CLA 2007-10-29 09:07:20 EDT
bug 207498: "stop automatic configuration retrieval if already done" should be marked a duplicate of this.
Comment 9 Steffen Pingel CLA 2007-10-29 13:39:02 EDT

*** This bug has been marked as a duplicate of bug 207498 ***
Comment 10 Steffen Pingel CLA 2007-10-29 13:55:36 EDT
Thanks for pointing that out. We will make sure that we review patches and assign bugs accordingly but it can sometimes take a few days before we get to a particular bug. Please be patient If there is no immediate response and holler if no one comments within a week.

(In reply to comment #5)
> Should reallly be a per config date, but that is a lot more work

I agree that this should be stored per repository/configuration data and it would be worth the extra effort. Let's continue this discussion on bug 207498.