Community
Participate
Working Groups
If authentication fails the user should be prompted for the password.
Created attachment 81791 [details] patch
Created attachment 81792 [details] mylyn/context/zip
Committed patch to CVS.
Something is seriously wrong with this implementation. There are number of severe usability issues in the last dev build that didn't exist before: -- I've got asked user and password for the same jira repository about 10 times or so -- I've got asked for the passwords for repositories that I have no tasks (just checked checked the Archive category using "group by repository") -- password dialog doesn't say anywhere that the password is for the jira repository and it doesn't show any branding and that is very confusing -- when I enter the password I have no way to verify if password is correct. the "verify" button on the task repository dialog is very useful and we should provide it on the password dialog too.
(In reply to comment #4) > -- I've got asked user and password for the same jira repository about 10 times > or so Did you enter the correct password? You will be prompted again when you enter the wrong password (and do not hit cancel). > -- I've got asked for the passwords for repositories that I have no tasks (just > checked checked the Archive category using "group by repository") Do you have automatic synchronization enabled? Please see the description for bug 208333. > -- password dialog doesn't say anywhere that the password is for the jira > repository and it doesn't show any branding and that is very confusing Jup, that could be improved. The CVS password dialog does not have much branding either but it would certainly help to add the appropriate repository icon to the password dialog. > -- when I enter the password I have no way to verify if password is correct. the > "verify" button on the task repository dialog is very useful and we should > provide it on the password dialog too. If you enter the wrong password the password dialog will come up again. No need for a verification button.
(In reply to comment #5) > Did you enter the correct password? You will be prompted again when you enter > the wrong password (and do not hit cancel). How do I know if I didn't? There isn't any error or warning. > Do you have automatic synchronization enabled? Please see the description for > bug 208333. Yes I do have automatic sync enabled and yet that is not a reason to ask for the password. The password request should be happening when server request goes out, but not when "maybe server request will be made" > If you enter the wrong password the password dialog will come up again. No need > for a verification button. There is a very big need in "verify", unless reappearing dialog will clearly communicate that password is invalid, or there is some other kind of error happens.
(In reply to comment #6) > > Did you enter the correct password? You will be prompted again when you enter > > the wrong password (and do not hit cancel). > > How do I know if I didn't? There isn't any error or warning. The behavior is consistent with the CVS plug-in. The password dialog is displayed when authentication fails and displays a message: "Please enter repository password". If it was unclear to you what you were supposed to do, please make suggestions for improvements. > > Do you have automatic synchronization enabled? Please see the description for > > bug 208333. > > Yes I do have automatic sync enabled and yet that is not a reason to ask for the > password. The password request should be happening when server request goes out, > but not when "maybe server request will be made" The background synchronization triggers the password dialog. Please read my previous answer.
(In reply to comment #7) > The behavior is consistent with the CVS plug-in. The password dialog is > displayed when authentication fails and displays a message: "Please enter > repository password". If it was unclear to you what you were supposed to do, > please make suggestions for improvements. I am saying that this implementation breaks user experience that we had before. Dialog jumps out of nowhere (even if you already trying to edit password for the same repository) and dialog don't provide clear user feedback. Repeating things I've said in my previous comments: -- password dialog should have "validate" button similar to repository properties -- password dialog should provide a clear error message, i.e. "invalid user user credentials", or "missing user credentials", or "auth failed" -- one more that haven't been mentioned before. If user is on the repository properties dialog, password dialog should not popup. Also, it doesn't matter that dialog is consistent with CVS, the one from CVS is also nowhere close to be usable.
(In reply to comment #8) > I am saying that this implementation breaks user experience that we had before. > Dialog jumps out of nowhere (even if you already trying to edit password for the > same repository) and dialog don't provide clear user feedback. We could consider only triggering the prompt if a repository connection was initiated by the user. > -- one more that haven't been mentioned before. If user is on the repository > properties dialog, password dialog should not popup. That is a minor problem with the current implementation and the user always has the possibility to hit "Cancel" to continue editing in the repository properties dialog. I am against suppressing the password popup but the repository settings dialog could update to the credentials entered in the password dialog. Need more input.
Further streamlining of password prompting is discussed on bug 210483.
