This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 207619 - [CommonNavigator] StackOverflowError when attempting to import with at least 2 projects in workspace
Summary: [CommonNavigator] StackOverflowError when attempting to import with at least ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Michael D. Elder CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 206957 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-10-26 15:50 EDT by Amy Wu CLA
Modified: 2007-10-30 09:57 EDT (History)
4 users (show)

See Also:

Attachments
overflow.log (90.32 KB, application/octet-stream)
2007-10-26 15:51 EDT, Amy Wu CLA 		no flags Details
Porting action provide v01 (1.31 KB, patch)
2007-10-29 13:47 EDT, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amy Wu CLA 2007-10-26 15:50:49 EDT 
using eclipse-SDK-I20071023-0800-win32

1. switch to resource perspective
2. create 2 projects (simple or java)
3. file -> import...

You get a stack overflow error.  This does not seem to happen if you're in the Java perspective.  Maybe related to project explorer.
Comment 1 Amy Wu CLA 2007-10-26 15:51:56 EDT 
Created attachment 81293 [details]
overflow.log

here's the log.
Comment 2 Kevin McGuire CLA 2007-10-29 11:54:46 EDT 
I've been able to reproduce this in 1017.  Its true it only happens in the Project Explorer (doesn't matter perspective).  

Assigning to CommonNavigator because it seems particular to it. However, there's nothing CommonNavigator specific in the recursion, its all command handler service stuff, so CC'ing Paul.
Comment 3 Kevin McGuire CLA 2007-10-29 11:58:50 EDT 
Note this is a regression since M2.
Comment 4 Paul Webster CLA 2007-10-29 12:38:02 EDT 
(In reply to comment #2)
> Assigning to CommonNavigator because it seems particular to it. However,
> there's nothing CommonNavigator specific in the recursion, its all command
> handler service stuff, so CC'ing Paul.

It's back further in the trace :-)

ImportResourcesAction is being registered as an ActionHandler for the import command, but with the 3.4 changes it is then calling the import command (ActionFactory.IMPORT returns a WorkbenchCommandAction).

Thinking ...

PW
Comment 5 Paul Webster CLA 2007-10-29 13:47:53 EDT 
Created attachment 81483 [details]
Porting action provide v01

This removes the calls to setGlobalActionHandler(*) from the porting provider and removes the loop.

Both context menu actions and the global actions work fine.

I need to analyze the ImportResourcesAction to see if it should be an action added to cycle prevention in setGlobalActionHandler(*) ... but that's not exactly a scalable solution.

PW
Comment 6 Paul Webster CLA 2007-10-29 15:19:21 EDT 
Released to HEAD >20071029
PW
Comment 7 Paul Webster CLA 2007-10-30 08:55:11 EDT 
In I20071030-0010, both File>Import... and Export... open the appropriate dialog.

PW
Comment 8 Paul Webster CLA 2007-10-30 09:57:14 EDT 
*** Bug 206957 has been marked as a duplicate of this bug. ***