Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 207602 - [performance] assigning projects to workings sets very slow
Summary: [performance] assigning projects to workings sets very slow
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-26 14:02 EDT by Steffen Pingel CLA
Modified: 2007-12-18 20:17 EST (History)
0 users

See Also:


Attachments
cpu profiling (730.19 KB, application/octet-stream)
2007-10-26 14:18 EDT, Steffen Pingel CLA
no flags Details
fix (5.56 KB, patch)
2007-12-18 19:46 EST, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (3.96 KB, application/octet-stream)
2007-12-18 19:46 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2007-10-26 14:02:06 EDT
When I assign multiple projects to a Java working set in the Package Explorer Eclipse stalls and the operation takes a long time to complete. Most of the CPU time seems to be spent by Mylyn's TaskListView. I'll attach an export of the CPU profiling results.
Comment 1 Steffen Pingel CLA 2007-10-26 14:18:32 EDT
Created attachment 81284 [details]
cpu profiling
Comment 2 Steffen Pingel CLA 2007-11-01 19:48:51 EDT
Another oddity I have noticed with Java working sets is that when I shutdown my bootstrapped workspace all the Java working sets created in that Eclipse session vanished (my old ones were still there). When I ran the workspace without Mylyn enabled all new working sets were saved as expected. I could not reproduce that with my test workspace so this could be a timing issue during shutdown.
Comment 3 Steffen Pingel CLA 2007-12-14 19:36:00 EST
Mik, we have to take a look at this together next week and review TaskListView.propertyChange(). The task list is expanded each time a change is made to a working set which is causing the slow down.
Comment 4 Mik Kersten CLA 2007-12-14 22:31:46 EST
Sound good.  Let's look at it early Monday.
Comment 5 Steffen Pingel CLA 2007-12-18 19:46:44 EST
Created attachment 85502 [details]
fix

Mik, please review this patch. It checks if a change event for a working set affects the filter, i.e. if the visible elements changed and only then refreshes the task list.
Comment 6 Steffen Pingel CLA 2007-12-18 19:46:46 EST
Created attachment 85503 [details]
mylyn/context/zip
Comment 7 Mik Kersten CLA 2007-12-18 20:17:54 EST
Patch reviewed and applied.  

Steffen: please do some additional manual testing.  I'll bootstrap right now because problems with this code tend to be manifest worst at startup.