Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 207598 - make TaskListToolTip code re-usable
Summary: make TaskListToolTip code re-usable
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 205861
  Show dependency tree
 
Reported: 2007-10-26 13:22 EDT by Nathan Hapke CLA
Modified: 2008-10-30 01:13 EDT (History)
1 user (show)

See Also:


Attachments
protected visibility patch (18.27 KB, patch)
2007-10-26 13:26 EDT, Nathan Hapke CLA
no flags Details | Diff
mylyn/context/zip (1.42 KB, application/octet-stream)
2007-10-26 13:26 EDT, Nathan Hapke CLA
no flags Details
mylyn/context/zip (2.28 KB, application/octet-stream)
2007-11-06 18:03 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Hapke CLA 2007-10-26 13:22:18 EDT
I realize that Mylyn isn't out there to make a really great generic tooltip class, but by making a couple of methods protected access I'm able to re-use a lot of the code, which saved me a bunch of time.
Comment 1 Nathan Hapke CLA 2007-10-26 13:26:06 EDT
Created attachment 81281 [details]
protected visibility patch
Comment 2 Nathan Hapke CLA 2007-10-26 13:26:10 EDT
Created attachment 81282 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2007-10-26 13:33:44 EDT
Nathan, could you describe your use-case for extending the tooltip? We can make these methods protected but please note that TaskListTooltip is an internal class that may (and is likely to) change in the future.
Comment 4 Nathan Hapke CLA 2007-10-26 13:51:47 EDT
I've got a tree viewer like the tasklist with one level of categorization.  I had copied TaskListTooltip initially, but then noticed that I wasn't making any changes to most of the methods I was copying.  I realize it's internal.
Comment 5 Mik Kersten CLA 2007-10-26 13:59:30 EDT
Steffen: this patch looks fine to me, because it's internals, so the responsibility will be entirely on the extender in terms of maintaining their code.
Comment 6 Steffen Pingel CLA 2007-10-26 15:57:57 EDT
Agreed. I can't commit to the task framework, over to you.
Comment 7 Steffen Pingel CLA 2007-10-27 05:13:07 EDT
Just to clarify: the reason why I asked for a use case is that we have another request for making the tool tip more extensible (bug 197345). Apparently this use case is entirely different and is best addressed by making the methods protected.
Comment 8 Steffen Pingel CLA 2007-11-06 18:03:27 EST
Nathan, I have made the changes suggested in your patch. I only made a slight modification to the method name for creating the composite: it is called  createToolTipContentAreaComposite() instead of createSurface(). Please verify that I didn't miss anything. 
Comment 9 Steffen Pingel CLA 2007-11-06 18:03:31 EST
Created attachment 82278 [details]
mylyn/context/zip
Comment 10 Nathan Hapke CLA 2007-11-06 19:22:23 EST
Verified. Thanks.