Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 207565 - RFE: "show filtered children" menu option should be a toggle
Summary: RFE: "show filtered children" menu option should be a toggle
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-26 06:54 EDT by Andre Costa CLA
Modified: 2007-11-16 21:55 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Costa CLA 2007-10-26 06:54:18 EDT
Build ID: M20070921-1145

Steps To Reproduce:
1. right-click an a class on the package explorer and choose "show filtered children" on the popup menu
2. 
3.


More information:
Once you choose to visualize filtered children there's no way to undo this unless you choose the parent node (the Java file) and filter its children. This seems like a side-effect to me.

I guess the "show filtered children" menu option should be a toggle that would reflect the state of the node that was clicked, and should hide filtered children when deactivated. Either this or there should be an explicit "hide filtered children" option, but IMHO the toggle is a more elegant alternative.
Comment 1 Andre Costa CLA 2007-10-26 06:58:50 EDT
PS: There's some discussion about this on bug 206503.
Comment 2 Mik Kersten CLA 2007-11-01 19:10:33 EDT
Andre: I have done one better for you.  If you make a non-Alt click, the unfiltered elements will go away.  That can be either a right click or a left click, so you don't need to invoke the popup menu action to see this behavior.  This will be in the next weekly build: http://www.eclipse.org/mylyn/downloads
Comment 3 Eugene Kuleshov CLA 2007-11-02 01:00:45 EDT
Mik, will this "non-Alt" click interfere with the popup menu (right-click) or selection (shift or ctrl-click)?
Comment 4 Andre Costa CLA 2007-11-02 09:47:07 EDT
(In reply to comment #2)
> Andre: I have done one better for you.  If you make a non-Alt click, the
> unfiltered elements will go away.  That can be either a right click or a left
> click, so you don't need to invoke the popup menu action to see this behavior. 
> This will be in the next weekly build: http://www.eclipse.org/mylyn/downloads
> 

Hi Mik,

you mean, I will still be able to show filtered children through the menu option (since Alt+click no Linux defaults to window move), but once filtered children are shown I just need to left- or right-click on the node to make them go away?

If that's so, I liked it =) -- should be simple enough, and IMHO showing filtered children should be able to go away easily.

Thks for giving it a shot =)

Regards,

Andre

PS: I agree with Eugene though that this behavior should not interfere with regular left- and right-clicking.
Comment 5 Eugene Kuleshov CLA 2007-11-05 13:40:38 EST
 (In reply to comment #2)
> Andre: I have done one better for you.  I

Mik, I am tempted to reopen this because your changes severely broke unfiltering. I can't open editor or popup menu on the temporarily unfiltered items. Running latest dev build and Eclipse 3.4m3
Comment 6 Mik Kersten CLA 2007-11-16 21:55:17 EST
Eugene: for anything remaining that's broken please open a new bug (if you haven't already).  I will review the things we discussed during the call next week.