Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 207308 - Removing a file type should not delete the platform's file association to editors
Summary: Removing a file type should not delete the platform's file association to edi...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.0 M4   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 208951
Blocks:
  Show dependency tree
 
Reported: 2007-10-24 10:01 EDT by Stephen Davison CLA
Modified: 2007-11-14 13:57 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Davison CLA 2007-10-24 10:01:11 EDT
Removing a file type from Preferences -> Remote Systems -> Files also deletes the file association usually shown in General -> Editors -> File Associations.  
It doesn't seem right that RSE can delete editor file assocations from the platform when it's really only concerned with text vs binary file transfer.

On another topic; this is my first bug report using Mylyn.  I like it a lot.
Comment 1 Martin Oberhuber CLA 2007-10-25 08:43:33 EDT
I find this a major issue since it leads to unexpected loss of data.
Dave would you the one dealing with file associations?
Comment 2 David McKnight CLA 2007-11-05 15:39:16 EST
This one could be tricky because it appears the preference page gets that file list directly from the editor preferences (i.e. there is no separate RSE representation of file associations).  That means if a user adds or removes a file type, it's effecting the editor preferences directly. 

I'm not sure what the best way to address this.  Should we redesign this so that RSE maintains it's own list of file types?  That doesn't mean a little bit of duplication although perhaps we can help that by distinguishing between RSE-specific file types and Eclipse editor associations (for example, we could set our own preference page up such that the eclipse associations can't be added or removed, while the complementary RSE ones can.

Another easier approach to this could be to only allow the removal of a file type when it was added prior to committing the change (via Apply or Ok).  That way the editor associations that exist before working in the RSE preference page are never deleted via the RSe preference page. 

Any thoughts on this?
Comment 3 David McKnight CLA 2007-11-14 13:36:39 EST
Bug 208951, introducing the remoteFileTypes extension point, will be used to solve this problem.  Rather that using the editor registry, we will default our extensions based on the remoteFileTypes that have been contributed.  All changes via the user will apply only to RSE's list, and not the editor registry.  	

Comment 4 David McKnight CLA 2007-11-14 13:57:28 EST
I've put the changes in for bug 208951, so this should now be fixed.