This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 206913 - source annotations are not painting in source editors
Summary: source annotations are not painting in source editors
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: 3.0 M3   Edit
Assignee: Amy Wu CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-19 12:15 EDT by Amy Wu CLA
Modified: 2007-10-25 13:55 EDT (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
org.eclipse.wst.sse.ui.patch (4.50 KB, patch)
2007-10-19 14:54 EDT, Amy Wu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amy Wu CLA 2007-10-19 12:15:07 EDT 
using wtp 3.0M3 20071019040808 sdk

source annotations are not painting in source editors
spelling, xml, jsp, any other validation errors/warnings are not appearing in the editor.  they show up in the overview ruler though.

it looks to be a platform base-related issue because it was working fine on eclipse-SDK-I20071002-1342 and then after moving up to eclipse-SDK-I20071010-1200 it didnt work.

source annotations are paiting for text & java editors though
Comment 1 Amy Wu CLA 2007-10-19 13:14:15 EDT 
probably related to platform bug 201928 in some way
Comment 2 Amy Wu CLA 2007-10-19 14:54:04 EDT 
Created attachment 80792 [details]
org.eclipse.wst.sse.ui.patch

Bug 201928 created a new squiggle drawing strategy to use that depends on a presentation reconciler to paint the squigglies on the editor.  Unfortunately, StructuredTextEditors cannot use the presentation reconciler because it conflicts with its highlighter. 

To work around this problem, I've created a subclass of SourceViewerDecorationSupport and overrode createAnnotationPainter() so that it uses the old squiggly painter (which does not require a presentation reconciler) instead of the new one.

Then in StructuredTextEditor, I overrode getSourceViewerDecorationSupport() so that it uses this new subclass.
Comment 3 Amy Wu CLA 2007-10-19 14:55:53 EDT 
This fix appears to work for now, but we should look into a better solution in the near future since the old squiggly drawing strategy has been deprecated.
Comment 4 Nitin Dahyabhai CLA 2007-10-19 15:40:13 EDT 
Looks good.
Comment 5 Amy Wu CLA 2007-10-19 15:51:52 EDT 
fix released to head and requesting a respin to get fix in to this week's ibuild.
Comment 6 Nitin Dahyabhai CLA 2007-10-19 20:40:26 EDT 
Verified with I20071019201738.
Comment 7 Amy Wu CLA 2007-10-25 13:51:43 EDT 
closing
Comment 8 Amy Wu CLA 2007-10-25 13:55:41 EDT 
Like  said in comment #3, the fix put in works for now, but we're using a deprecated class.  I'm going to use bug 108394 to fix this bug better in the longer run.