Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 206752 - [OLE] Error when opening not SQL files
Summary: [OLE] Error when opening not SQL files
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-18 09:34 EDT by George Munteanu CLA
Modified: 2008-04-30 10:51 EDT (History)
2 users (show)

See Also:

Attachments
Fix (2.48 KB, patch)
2007-10-22 12:19 EDT, Dani Megert CLA 		no flags Details | Diff
Fix (2.99 KB, patch)
2007-11-06 11:46 EST, Dani Megert CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Munteanu CLA 2007-10-18 09:34:29 EDT 
Build ID: I20070625-1500

Steps To Reproduce:
1.Start Eclipse 
2.Open a file with .doc extension (File->Open File).
3. The file is not opened and error appears ('Error opening the editor').
Also, in the Error Log view this error is displayed: 'Unable to create editor ID org.eclipse.ui.systemInPlaceEditor: Invalid Input: org.eclipse.ui.ide.FileStoreEditorInput@f40f9b40. Input must adapt to IFile')
Comment 1 Dani Megert CLA 2007-10-22 10:28:21 EDT 
Fixed in HEAD.
Available in builds > N20071022-0010.

This is a regression that got introduced in 3.3 as we replaced the internal JavaFileEditorInput with FileStoreEditorInput which (correctly) does not implement IPathEditorInput. The OleEditor.java must use the IPathEditorInput adapter.

As the fix is easy and straight forward we might consider this for 3.3.2.

Tod, what's you take on this?
Comment 2 Tod Creasey CLA 2007-10-22 11:42:33 EDT 
Sounds like a good idea Dani - could you attach a patch please?
Comment 3 Dani Megert CLA 2007-10-22 12:19:25 EDT 
Created attachment 80886 [details]
Fix
Comment 4 Mike Wilson CLA 2007-10-23 11:01:22 EDT 
+1
Comment 5 Dani Megert CLA 2007-10-23 11:26:20 EDT 
Tod, I can put it into the maintenance stream if you want. Do you guys automatically contribute (i.e. tag) to the M-builds or do you do it when you backport a fix?
Comment 6 Dani Megert CLA 2007-11-06 11:46:46 EST 
Created attachment 82218 [details]
Fix

This fix causes a regression (see 208897) due to bug 120336 but backporting the fix for bug 120336 will be too dangerous. This new fix works around bug 120336.
Comment 7 Dani Megert CLA 2008-04-29 05:53:57 EDT 
This is fixed in 3.4 but didn't get backported to 3.3.x.
Comment 8 Dani Megert CLA 2008-04-30 10:51:01 EDT 
Verified in I2080430-0100.