Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 206266 - Provide better support for adding to and for accessing InternalEList
Summary: Provide better support for adding to and for accessing InternalEList
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Core (show other bugs)
Version: 2.4.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Ed Merks CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 204200 206267
  Show dependency tree
 
Reported: 2007-10-14 12:35 EDT by Ed Merks CLA
Modified: 2008-01-28 16:41 EST (History)
1 user (show)

See Also:

Attachments
Change to update InternalEList and downstream classes (60.21 KB, patch)
2007-10-14 12:38 EDT, Ed Merks CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Merks CLA 2007-10-14 12:35:03 EDT 
It's useful to have addAllUnique support as well as basic (non-resolving) methods for toArray, contains, containsAll, indexOf, and lastIndexOf.  All these things allow serializers and deserializers more efficient access and can be used to improve XMLHelperImpl by avoiding unnecessary and expensive proxy resolves.
Comment 1 Ed Merks CLA 2007-10-14 12:38:23 EDT 
Created attachment 80320 [details]
Change to update InternalEList and downstream classes

This also includes improvements to the XMI code to take advantage of the changes.
Comment 2 Ed Merks CLA 2007-10-14 12:40:56 EDT 
Kenn,

There are changes in DerivedEObjectEList.  I created a new base class so that future changes to InternalEList can hopefully be handled in the base class.  There's one gratuitous change in there to not disable move; I'm not sure why move would be disabled for a non-readonly list.  If you're okay with these changes, I'll commit this early this weak, at which point the changes in the UML list need to be committed as well.
Comment 3 Kenn Hussey CLA 2007-10-17 09:50:57 EDT 
The UML2 changes look fine to me; ready to commit when you are.
Comment 4 Ed Merks CLA 2007-10-20 10:46:14 EDT 
The changes are committed to CVS.  Please be sure to commit the UML2 change!
Comment 5 Nick Boldt CLA 2007-10-23 22:43:45 EDT 
Fixed in I200710232100.
Comment 6 Nick Boldt CLA 2008-01-28 16:41:45 EST 
Move to verified as per bug 206558.