Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 206137 - prSrcPaths: error if more then 1 path
Summary: prSrcPaths: error if more then 1 path
Status: CLOSED FIXED
Alias: None
Product: M2T
Classification: Modeling
Component: Xpand (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Karsten Thoms CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-12 08:51 EDT by ekkehard gentz CLA
Modified: 2013-02-21 08:11 EST (History)
2 users (show)

See Also:


Attachments
Patch (16.70 KB, patch)
2008-01-23 01:57 EST, Karsten Thoms CLA
sven.efftinge: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ekkehard gentz CLA 2007-10-12 08:51:03 EDT
a workflow entry like
<prSrcPaths value="${outlet.res.pr.dir}, ${outlet.src.pr.dir}"/>
doesn't work. both values ${outlet.res.pr.dir} and ${outlet.src.pr.dir} are valid - if I use only one of them, it works.
with both running the workflow causes an error with the last entry in the srcPathsList

RROR - Source path component  ../org.ekkehard.verwaltung/src/gen-pr/java not found or no directory
org.openarchitectureware.workflow.ConfigurationException: Source path component  ../org.ekkehard.verwaltung/src/gen-pr/java not found or no directory
	at org.openarchitectureware.xpand2.pr.ProtectedRegionResolverImpl.init(ProtectedRegionResolverImpl.java:304)
	at org.openarchitectureware.xpand2.pr.ProtectedRegionResolverImpl.getProtectedRegion(ProtectedRegionResolverImpl.java:260)
	at org.openarchitectureware.xpand2.ast.ProtectStatement.evaluateInternal(ProtectStatement.java:91)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.IfStatement.evaluateInternal(IfStatement.java:96)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.AbstractDefinition.evaluate(AbstractDefinition.java:158)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.invokeDefinition(ExpandStatement.java:198)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.evaluateInternal(ExpandStatement.java:170)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.FileStatement.evaluateInternal(FileStatement.java:83)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.IfStatement.evaluateInternal(IfStatement.java:96)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.AbstractDefinition.evaluate(AbstractDefinition.java:158)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.invokeDefinition(ExpandStatement.java:198)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.evaluateInternal(ExpandStatement.java:170)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.LetStatement.evaluateInternal(LetStatement.java:68)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.AbstractDefinition.evaluate(AbstractDefinition.java:158)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.invokeDefinition(ExpandStatement.java:198)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.evaluateInternal(ExpandStatement.java:148)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.AbstractDefinition.evaluate(AbstractDefinition.java:158)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.invokeDefinition(ExpandStatement.java:198)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.evaluateInternal(ExpandStatement.java:148)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.ast.AbstractDefinition.evaluate(AbstractDefinition.java:158)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.invokeDefinition(ExpandStatement.java:198)
	at org.openarchitectureware.xpand2.ast.ExpandStatement.evaluateInternal(ExpandStatement.java:170)
	at org.openarchitectureware.xpand2.ast.Statement.evaluate(Statement.java:34)
	at org.openarchitectureware.xpand2.Generator.invokeInternal2(Generator.java:246)
	at org.openarchitectureware.expression.AbstractExpressionsUsingWorkflowComponent.invokeInternal(AbstractExpressionsUsingWorkflowComponent.java:153)
	at org.openarchitectureware.workflow.lib.AbstractWorkflowComponent2.invoke(AbstractWorkflowComponent2.java:38)
	at org.openarchitectureware.workflow.container.CompositeComponent.internalInvoke(CompositeComponent.java:95)
	at org.openarchitectureware.workflow.container.CompositeComponent.invoke(CompositeComponent.java:84)
	at org.openarchitectureware.workflow.container.CompositeComponent.internalInvoke(CompositeComponent.java:95)
	at org.openarchitectureware.workflow.container.CompositeComponent.invoke(CompositeComponent.java:84)
	at org.openarchitectureware.workflow.container.CompositeComponent.internalInvoke(CompositeComponent.java:95)
	at org.openarchitectureware.workflow.container.CompositeComponent.invoke(CompositeComponent.java:84)
	at org.openarchitectureware.workflow.WorkflowRunner.executeWorkflow(WorkflowRunner.java:290)
	at org.openarchitectureware.workflow.WorkflowRunner.run(WorkflowRunner.java:206)
	at org.openarchitectureware.workflow.WorkflowRunner.main(WorkflowRunner.java:158)
Comment 1 Bernd Kolb CLA 2007-10-12 09:12:07 EDT
And you are sure that this
Source path component  ../org.ekkehard.verwaltung/src/gen-pr/java not found or no directory

is not the problem? Does this path exist?

Bernd
Comment 2 ekkehard gentz CLA 2007-10-12 10:03:35 EDT
yes, I'm sure.
I can use
<prSrcPaths value="${outlet.res.pr.dir}"/>
or
<prSrcPaths value="${outlet.src.pr.dir}"/>
but not both together. no matter which order, the exception is always for the 2nd in the list of paths
Comment 3 Manfred Klug CLA 2007-10-12 10:17:17 EDT
Try it without blank after the comma.
Comment 4 ekkehard gentz CLA 2007-10-12 11:12:58 EDT
thanks. this works :-)

but its not consistent, because

<component id="dirCleaner" class="org.openarchitectureware.workflow.common.DirectoryCleaner">
		<directories value="${outlet.src.dir}, ${outlet.aop.dir}, ${outlet.res.dir}"/>
</component>
	
works with spaces.
ekke
Comment 5 Bernd Kolb CLA 2007-10-13 04:41:59 EDT
so it is a bug in the generator-component?
Comment 6 Karsten Thoms CLA 2007-10-13 04:48:51 EDT
Not looked at it yet. Guess is that there needs to be trim() on the path decomposition. I will examine it.
Comment 7 Karsten Thoms CLA 2008-01-23 01:56:39 EST
Fixed in branch 4.2. 

For HEAD moving to M2T
Comment 8 Karsten Thoms CLA 2008-01-23 01:57:18 EST
Created attachment 87608 [details]
Patch

Patch including unit test
Comment 9 Karsten Thoms CLA 2008-01-23 16:58:01 EST
The problem was the space after the comma. The entries must be trimmed.

Now also fixed in HEAD.
Comment 10 Nick Boldt CLA 2008-01-28 16:57:47 EST
Move to verified as per bug 206558.
Comment 11 Karsten Thoms CLA 2013-02-21 08:11:22 EST
Bug resolved before Xpand 1.2 release date => Closing