Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 205584 - PDE Rename participant does not check out plugin.xml
Summary: PDE Rename participant does not check out plugin.xml
Status: RESOLVED WORKSFORME
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-05 11:35 EDT by Benno Baumgartner CLA
Modified: 2019-09-02 15:08 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2007-10-05 11:35:58 EDT
I20071002-1342

1. Create new Plugin Project
2. Add extension to org.eclipse.ui.startup
3. Share the plugin project using the pessimistic team provider (from org.eclipse.team.examples.filesystem)
4. Add plugin.xml and check in
5. Refactor>Rename the IStartup implementor
Is:
 Error 'The file xy/plugin.xml' is read-only
Should:
 Ask to check out plugin.xml
Comment 1 Markus Keller CLA 2007-10-05 12:54:55 EDT
FYI: I just added Javadoc to org.eclipse.ltk.core.refactoring.participants.
RefactoringParticipant#checkConditions(IProgressMonitor, CheckConditionsContext)
that explains how implementors should register their resource operations:
  
  (ResourceChangeChecker) context.getChecker(ResourceChangeChecker.class);
  IResourceChangeDescriptionFactory deltaFactory= checker.getDeltaFactory();
  deltaFactory. /*register your changes here*/
Comment 2 Kristina Taylor CLA 2008-03-10 15:34:14 EDT
FYI, this seems to be a case where the PDE is checking the file's attributes before whatever it is that triggers the  org.eclipse.core.resources.fileModificationValidator extension point fires, and thus failing the refactor operation prematurely and erroneously.

The fileModificationValidators do get called at some point, because I have implemented one that immediately sets files to writable before spawning a job to do other things.  If I do a refactoring in a plugin that affects a plugin.xml file, the file get set to writable (as expected), but any associated refactorings fail because the PDE seems to only check the file's attributes before the modification validator is asked to do its work.
Comment 3 Eclipse Genie CLA 2019-02-27 19:46:20 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Lars Vogel CLA 2019-09-02 15:02:58 EDT
This bug has been marked as stalebug a while ago without any further interaction.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard flag.
Comment 5 Lars Vogel CLA 2019-09-02 15:08:05 EDT
This bug was marked as stalebug a while ago. Marking as worksforme.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.