Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 20510 - [GlobalActions] Add Bookmark action has wrong label in navigator or packages view
Summary: [GlobalActions] Add Bookmark action has wrong label in navigator or packages ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Simon Arsenault CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 17759 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-06-17 16:36 EDT by Randy Giffen CLA
Modified: 2003-08-07 06:59 EDT (History)
2 users (show)

See Also:

Attachments
Dialog to enter Bookmark name (3.14 KB, patch)
2002-11-07 11:53 EST, Sebastian Davids CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Giffen CLA 2002-06-17 16:36:54 EDT 
F3

1) Select a .java file in the Navigator
2) Edit>Add Bookmark... 
3) No dialog opens
4) Open the bookmarks view and see that a bookmark was added.

Either the action should open a dialog as it does in the editor or its label 
should be changed.
Comment 1 Sebastian Davids CLA 2002-11-07 11:53:08 EST 
Created attachment 2338 [details]
Dialog to enter Bookmark name

Changed popup menu label from "Add Boo&kmark" to "Add Boo&kmark...".

The user can name the bookmark now.

The proposal is the file name.

A bookmark name consisting only of white-spaces is not allowed.
Comment 2 Sebastian Davids CLA 2002-11-07 11:56:35 EST 
We might consider adding a preference somewhere "Silent add of bookmarks" --
switch to old behavior.

If interested I'd try to implement that as well.
Comment 3 Simon Arsenault CLA 2002-11-15 13:17:52 EST 
Sabastian,

I just noticed that you attached a fixed for this PR. I will look at it as soon 
as I can.

If you fix another PR and you notice its assigned to Platform-*-
Inbox@eclipse.org, send an e-mail to the mailing list also. Otherwise, it may 
not get notice.
Comment 4 Simon Arsenault CLA 2002-11-18 13:42:01 EST 
Code patch applied. Minor changes to source code. Code released to HEAD.
Comment 5 Knut Radloff CLA 2003-01-13 13:59:39 EST 
*** Bug 17759 has been marked as a duplicate of this bug. ***