Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 205064 - [Contributions] Cannot create additions marker using org.eclipse.ui.menus
Summary: [Contributions] Cannot create additions marker using org.eclipse.ui.menus
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal with 1 vote (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 203791 209042
  Show dependency tree
 
Reported: 2007-10-01 11:06 EDT by Tod Creasey CLA
Modified: 2008-03-25 13:44 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2007-10-01 11:06:53 EDT 
M2

If I add in the additions seperator so that I don't get the missing additions warning using this entry in a menu contribution

 <separator
                name="additions"
                visible="false">
          </separator>

I will still get the warning because PopUpMenuExtender tests before it reads contributions


    	readStaticActions();
        testForAdditions();
        if (menuWrapper != null) {
            mgr = menuWrapper;
            menuWrapper.removeAll();
        }
        addMenuContributions(originalManager);

See org.eclipse.ui.ide for the menu contribution in Bug 203791
Comment 1 Tod Creasey CLA 2007-11-07 08:30:18 EST 
Paul do we have a workaround for this - it is annoying to people who use the error view.
Comment 2 Paul Webster CLA 2007-11-07 10:35:15 EST 
Released workaround, removed log.

PW
Comment 3 Paul Webster CLA 2008-03-09 13:08:24 EDT 
Released a non-api fix to HEAD >20080309

A menu contribution that has an additions separator now gets moved to the front of the queue for processing.  This will do for 3.4 (if you provide multiple additions markers the behaviour becomes less deterministic)

PW
Comment 4 Paul Webster CLA 2008-03-25 13:44:34 EDT 
In I20080325-0100
PW