Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 204936 - BPEL Source tab development
Summary: BPEL Source tab development
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BPEL (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: BPEL UI Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-28 13:16 EDT by Dennis Ushakov CLA
Modified: 2022-10-03 11:12 EDT (History)
3 users (show)

See Also:


Attachments
improved reconciliation algorithm (326.09 KB, patch)
2007-09-28 13:16 EDT, Dennis Ushakov CLA
no flags Details | Diff
copy-from-literal.patch (654 bytes, patch)
2007-09-29 20:10 EDT, Oleg Danilov CLA
no flags Details | Diff
properties.patch (1.27 KB, patch)
2007-09-29 20:12 EDT, Oleg Danilov CLA
no flags Details | Diff
vatiables, correlation sets and partner links adding patch (7.23 KB, patch)
2007-10-02 04:40 EDT, Dennis Ushakov CLA
no flags Details | Diff
sourcetab_20071008.patch (90.58 KB, patch)
2007-10-08 07:23 EDT, Oleg Danilov CLA
no flags Details | Diff
sourcetab_20071025.patch (63.95 KB, patch)
2007-10-25 10:40 EDT, Oleg Danilov CLA
no flags Details | Diff
next patch (Assign, etc) (18.62 KB, patch)
2007-11-02 06:57 EDT, Oleg Danilov CLA
no flags Details | Diff
sourcetab-20071116.patch (49.35 KB, patch)
2007-11-19 08:20 EST, Oleg Danilov CLA
no flags Details | Diff
sourcetab-20071123.patch (83.65 KB, patch)
2007-11-23 08:21 EST, Oleg Danilov CLA
no flags Details | Diff
sourcetab-20071130.patch (45.98 KB, patch)
2007-12-03 05:13 EST, Oleg Danilov CLA
no flags Details | Diff
from_patch.patch (2.92 KB, patch)
2007-12-06 07:48 EST, Oleg Danilov CLA
no flags Details | Diff
sourcetab-20071207.patch (10.93 KB, patch)
2007-12-11 05:46 EST, Oleg Danilov CLA
bbrodt: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Ushakov CLA 2007-09-28 13:16:29 EDT
Created attachment 79413 [details]
improved reconciliation algorithm

Continued source tab development in the HEAD
Approximately 40 percent of model elements are synchronizing correctly

Also following bugs are fixed
1) If I have sequence and add an empty activity before that then move
into the sequence somehow I have 2 empty activities in the sequence.
If a play with just a sequence and an empty activity I can do a lot of
visual damage :-)

2) Editing with 2 copies of the editor open (so 2 editors open for one
file, one shown in source view, the other in design view) does not
seem to work either.
Works correctly for approximately one third of elements, as it was announced

3) Adding a variable does not work.
Works ok.
Comment 1 Dennis Ushakov CLA 2007-09-28 13:24:23 EDT
(In reply to comment #0)
Sorry, made some mistakes =) Corrected version
> Also following bugs are fixed
> 1) If I have sequence and add an empty activity before that then move
> into the sequence somehow I have 2 empty activities in the sequence.
> If a play with just a sequence and an empty activity I can do a lot of
> visual damage :-)
Ok
 
> 2) Editing with 2 copies of the editor open (so 2 editors open for one
> file, one shown in source view, the other in design view) does not
> seem to work either.
Ok 

> 3) Adding a variable does not work.
Ok
Comment 2 Oleg Danilov CLA 2007-09-29 20:10:55 EDT
Created attachment 79443 [details]
copy-from-literal.patch

Node.getTextContent() causes DOMException if bpel contains <assign><copy><from><literal>. Fixed.
Comment 3 Oleg Danilov CLA 2007-09-29 20:12:07 EDT
Created attachment 79444 [details]
properties.patch

If we choose something in the Design view then Properties tab will contain something like &#8220;Properties are not available&#8221;. Fixed.
Comment 4 Dennis Ushakov CLA 2007-10-02 04:40:15 EDT
Created attachment 79534 [details]
vatiables, correlation sets and partner links adding patch

It seems I forgot to add variables to the big fix. Here it is. Adding variables should work correctly now
Comment 5 Oleg Danilov CLA 2007-10-08 07:23:38 EDT
Created attachment 79893 [details]
sourcetab_20071008.patch 

The next patch :-) Allows to sync Reply, Receive, Invoke, etc. Not all bpel elements are supported yet, but definitely, we are going to cover all of them... I hope...
Comment 6 Dennis Ushakov CLA 2007-10-08 11:58:12 EDT
(In reply to comment #5)
> Created an attachment (id=79893) [details]
> sourcetab_20071008.patch 
This patch makes https://bugs.eclipse.org/bugs/attachment.cgi?id=79534 obsolete

Comment 7 Oleg Danilov CLA 2007-10-25 10:40:21 EDT
Created attachment 81160 [details]
sourcetab_20071025.patch 

This patch resolves some issues:
- save issue
- "dirty editor"
- improved synchronization
Comment 8 Oleg Danilov CLA 2007-11-02 06:57:24 EDT
Created attachment 81937 [details]
next patch (Assign, etc)
Comment 9 Oleg Danilov CLA 2007-11-19 08:20:56 EST
Created attachment 83230 [details]
sourcetab-20071116.patch

- Sync for CorrelationSets
- Fixes for different namespace issues
- "Save as Image..." feature (https://bugs.eclipse.org/bugs/show_bug.cgi?id=208226)
Comment 10 Oleg Danilov CLA 2007-11-23 08:21:41 EST
Created attachment 83631 [details]
sourcetab-20071123.patch

Implemented EventHandler, Extension(s), Flow, Link(s), MessaggeExchange(s), OnEvent, OnMessage, PartnerActivity, Pick, Scope, ServiceRef, Source(s), Target(s), TerminationHandler sync
Comment 11 Oleg Danilov CLA 2007-12-03 05:13:17 EST
Created attachment 84299 [details]
sourcetab-20071130.patch

here is the new patch from Dennis:

- Implemented ExtensibilityElement sync
- Added unsetting of previous parameters before setting new in VariablePartAssignCategory
Comment 12 Oleg Danilov CLA 2007-12-06 07:48:36 EST
Created attachment 84624 [details]
from_patch.patch

Fixed problem with magically disappearing <from> element.
Comment 13 Simon Moser CLA 2007-12-08 07:14:16 EST
Assing this comment from Oleg's note on the mailing list to the bug: 

*********************

Hi!

I'm happy to announce that reconciliation is now complete and should
work for all elements. There's is an unimplemented handling of
ExtensibilityElement in Expression but this could be integrated as
independent patch.

So from the now on we're going to switch from committing big patches
to the bug 204936 to filing separate bugs and patches. There's one
more big patch to come fixing several critical errors in
reconciliation, but after that I suggest that we close 204936

And the last thing =) From the Monday, 10th I'm going for so long
awaited vacation till the end of the year

Thanks,
Dennis
Comment 14 Oleg Danilov CLA 2007-12-11 05:46:05 EST
Created attachment 84945 [details]
sourcetab-20071207.patch

This bug isn't closed yet, so let me suggest one more patch :-)

model:
- added cdata cache in order to not create new cdata for existing elements
- added parent is reconciling check for expression in from/to (transparent expression)
- added setElse(null) if there's no else element in dom

ui:
- now reconcileModelObjectForElement searches for first parent node that has corresponding model object in order to handle nested xml in the literal
Comment 15 Simon Moser CLA 2007-12-30 10:42:43 EST
I reviewed the last patch (sourcetab-20071207.patch) from Oleg and released it. 
I will now close this bug. 
However, the UI Part hat you mentioned, Oleg, was not part of the attachment. 
Please file a new bug for this. 
Comment 16 Robert Brodt CLA 2012-04-18 14:36:16 EDT
Comment on attachment 84945 [details]
sourcetab-20071207.patch

Updated iplog flag for v1.0 release review.