Community
Participate
Working Groups
Build ID: I20070625-1500 Steps To Reproduce: Create a Navigator context menu item for New->Untitled Text File, by adding the following to your plugin.xml: <extension point="org.eclipse.ui.navigator.navigatorContent"> <commonWizard type="new" wizardId="org.eclipse.ui.editors.wizards.UntitledTextFileWizard"> <enablement> <adapt type="org.eclipse.core.resources.IResource" /> </enablement> </commonWizard> </extension> This wizard does not have any pages. However, when you select it from the Navigator context menu, you will get an empty dialog with just Finish and Cancel buttons. This wizard works fine (the dialog is not displayed) when used from the main File->New menu. This is similar to bug 177468, which was the same problem but with wizards within Cheat Sheets. Here, the problem is within org.eclipse.ui.internal.navigator.wizards.WizardShortcutAction. In the run() method, just after the call to wizard.init(), but before the window.getShell(), we need to have: if (descriptor.canFinishEarly() && !descriptor.hasPages()) { wizard.performFinish(); return; } I have tested the above fix against the 3.3 (I20070625-1500) build and it works correctly.
Any possibility of getting this fixed for Eclipse 3.4? I am currently shipping a hacked version of org.eclipse.ui.navigator with my RCP app, just to get around this problem. I would like to avoid having to put the same hack into Eclipse 3.4 once I upgrade my RCP app.
We'll take a look for inclusion in the next milestone.
Just wanted to find out if this could be fixed in time for 3.4M7? I don't want to ship a hacked version of org.eclipse.ui.navigator, like we had to do for Eclipse 3.3... This is the only bug that is holding our product up from switching to 3.4. Here is the fix: In org.eclipse.ui.internal.navigator.wizards.WizardShortcutAction. In the run() method, just after the call to wizard.init(), but before the window.getShell(), we need to have: if (descriptor.canFinishEarly() && !descriptor.hasPages()) { wizard.performFinish(); return; } I just tried this against 3.4M6 and it fixes the problem.
Any chance of getting this into Eclipse 3.4.1? It sure would be nice if our product did not have to ship a hacked (and hence digitally unsigned) version of org.eclipse.ui.navigator.
Created attachment 112164 [details] Contains a fix for this issue Attached the proposed solution as a patch, all you need to do is apply and test; it would be great if this made it for the next release.
Chris, this came to my attention too late for 3.4.1 (there were many other CNF fixes that did get into 3.4.1, but somehow I missed this one). Sorry I did not get the time to do this for 3.5M2, hopefully it will be in soon and then you can take an I build with the fix.
Released to HEAD 3.5M5
