Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 204640 - ResourceSetDomainLink should implement IEditingDomainProvider
Summary: ResourceSetDomainLink should implement IEditingDomainProvider
Status: VERIFIED FIXED
Alias: None
Product: EMF Services
Classification: Modeling
Component: Transaction (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 normal
Target Milestone: ---   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-26 00:40 EDT by Jasper CLA
Modified: 2017-02-24 15:10 EST (History)
0 users

See Also:

Attachments
I think this does the trick (1.65 KB, patch)
2007-10-02 12:20 EDT, Ed Merks CLA 		wayne.beaton: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jasper CLA 2007-09-26 00:40:00 EDT 
FactoryImpl.createEditingDomain(ResourceSet) creates a reverse mapping between a ResourceSet and the EditingDomain being created, in the form of a ResourceSetDomainLink. This ResourceSetDomainLink is added as an adapter of the ResourceSet.

However, since ResourceSetDomainLink does not implement IEditingDomainProvider, a caller such as ItemPropertyDescriptor.setPropertyValue(...) trying to retrieve the ResourceSet's associated domain by querying the ResourceSet for an adapter for IEditingDomainProvider.class, receives null, even though the ResourceSet does in fact know its EditingDomain.

If ResourceSetDomainLink implemented IEditingDomainProvider, the problem would be fixed.
Comment 1 Ed Merks CLA 2007-10-02 12:20:43 EDT 
Created attachment 79559 [details]
I think this does the trick
Comment 2 Christian Damus CLA 2007-10-02 12:48:37 EDT 
What, no JUnit test?  :-)

Thanks, Ed.
Comment 3 Christian Damus CLA 2007-10-02 13:28:15 EDT 
Fix is committed to CVS HEAD (1.2 stream).
Comment 4 Christian Damus CLA 2007-10-03 18:04:16 EDT 
Fixed in EMF Transaction 1.2 build I200710031719.
Comment 5 Nick Boldt CLA 2008-01-28 16:35:24 EST 
Move to verified as per bug 206558.