This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 204331 - EAR Libraries not being added to EE 5 modules
Summary: EAR Libraries not being added to EE 5 modules
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows XP
: P1 critical (vote)
Target Milestone: 2.0.1 M201   Edit
Assignee: Jason Sholl CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-21 16:55 EDT by Jason Sholl CLA
Modified: 2007-09-25 12:34 EDT (History)
6 users (show)

See Also:
jgarms: pmc_approved+
cbridgha: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
cbridgha: pmc_approved? (naci.dai)
deboer: pmc_approved+
cbridgha: pmc_approved? (neil.hauge)


Attachments
patch (5.33 KB, patch)
2007-09-21 16:57 EDT, Jason Sholl CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Sholl CLA 2007-09-21 16:55:05 EDT
The 3 facet install delegates for EE 5 modules need to add the EAR Libraries classpath container.  Previously this container was being added by another thread, but that logic changed with bug 200369.  Because that bug was originally coded up for 1.5.5 where there were no EE 5 facet install delegates, the EE 5 facet install delegates were overlooked when checking this into the 2.x stream.  It is surprising that no one noticed this until now (Rob found it).
Comment 1 Jason Sholl CLA 2007-09-21 16:57:47 EDT
Created attachment 79016 [details]
patch

This patch adds the EAR Libraries classpath container for the EE 5 EJB, Application Client, and Web facet install delegates.
Comment 2 Jason Sholl CLA 2007-09-21 16:58:44 EDT
I have tested this patch with the UI.  Rob, Chuck, could you also look this patch over and test.
Comment 3 Rob Frost CLA 2007-09-21 17:16:08 EDT
Works as expected (tested all Java EE 5 project types); thanks for generating this patch so quickly, Jason.

Up'ing the priority since I feel this one must be fixed before 2.0.1 goes out.
Comment 4 Rob Frost CLA 2007-09-24 21:19:01 EDT
Adding as a hotbug request; although there is a simple work around for this (just add the cp container via the JDT UI), users have never previously been required to manually add this cp container so the regression here is going to cause serious confusion for Java EE 5 users and, since the fix is low risk, seems like one to repair before 2.0.1 ships.
Comment 5 Jason Sholl CLA 2007-09-25 10:03:54 EDT
If possible, I think we should include this in 201; all users creating new EE 5 projects will encounter this problem if we don't include it in 201.  Furthermore, this is a very simple and straight forward fix.
Comment 6 Chuck Bridgham CLA 2007-09-25 10:58:26 EDT
I tested this patch and it appears very safe, and is fixing an ugly problem.

We need to add a junit to catch this in the future  (Checking for the correct classpath)

Comment 7 Jason Sholl CLA 2007-09-25 12:34:57 EDT
code dropped to 2.0.1 and released for build.