Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 204135 - [Commands] Update CommandAction
Summary: [Commands] Update CommandAction
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Tim Mok CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 35358
  Show dependency tree
 
Reported: 2007-09-20 11:28 EDT by Paul Webster CLA
Modified: 2007-10-30 11:48 EDT (History)
2 users (show)

See Also:

Attachments
createCommand calls ParameterizedCommand.generateCommand(*), image descriptors are set in init(*) (3.99 KB, patch)
2007-09-25 09:22 EDT, Tim Mok CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2007-09-20 11:28:07 EDT 
Update CommandAction to use the new ParameterizedCommand.generateCommand(*) method instead of doing the work itself.

Also, initialize it with images if they are available from the ICommandImageService.  Check out how it's done in CommandContributionItem.

This might have to wait until next week after I've committed the ParameterizedCommand changes.

PW
Comment 1 Tim Mok CLA 2007-09-25 09:22:00 EDT 
Created attachment 79128 [details]
createCommand calls ParameterizedCommand.generateCommand(*), image descriptors are set in init(*)
Comment 2 Paul Webster CLA 2007-09-25 13:52:09 EDT 
Released in HEAD >20070925
PW
Comment 3 Tim Mok CLA 2007-10-30 11:48:25 EDT 
verified in I20071030-0010