Community
Participate
Working Groups
Build ID: 3.3 GA Steps To Reproduce: Scenario: Our launch configuration requires multiple files as input. When multiple files are selected and the bug button (icon) is pressed, the platform is only able to pass the first file to the launch shortcut. So the user will be asked again for the path(s) of the other file(s) when invoking our launch shortcut. The code that might be responsible for this behavior is in the "protected IResource getSelectedResource0()" method in SelectedResourceManager.java in the org.eclipse.debug.internal.ui.stringsubstitution package. In this method, the selection (which contains multiple files at this point) is casted into an instance of type IStructuredSelection named ss. Only the first element in ss will be initiated into an Object o, and this object named o then gets casted into an instance of type IResource called resource. And resource will be returned to the calling method and eventually be used to extract the file paths. As only the first element actually gets returned, so the other file paths will be lost before they are passed to the launch shortbut. As a result, our launch shortbut is not able to create a launch configuration properly and is forced to ask the user for input again. Expected behavior: all of the selections should be properly stored and passed on to the next function. The user should not be asked for input files again if he/she already selected them, and a debug session should start given the inputs. More information:
Consider for 3.4
Hi Darin, I just want to give you more information on the impact of this problem. Since not all files from the selection can be passed to our launch shortcut, our launch shortcut is unable to match the current selection with any of the existing launch configurations. We do matching by comparing the current selection with the resources associated with the launch configurations. As a result, our launch shortcut will go off to create a new launch configuration every time context launching is used. This pollutes the user's workspace as we end up creating launch configurations unnecessarily. If the user has configured the source lookup path differently, the user will have to re-configure with the new launch configuration. Alternatively, we can change our code so that if the selected resource matches one of the resources in our launch configurations, then we can consider the launch config a match. However, this will likely create conflicts and the user will end up having to pick a launch configuration to launch. Thanks... Sam
Sam, I believe you should be able to work around this problem in 3.4 with the new API on ILaunchShortcut2, by implementing "getLaunchConfigurations(ISelection selection)". We pass the entire selection to the shortcut, which can determine the correct configuration(s) to choose from. The shortcut can return 3 options: * null - indicates the selection does not apply * empty collection - indicates the selection applies with no existing configs * 1 or more configs - launch the config or select from multiple When you return an empty collection the shortcut will be asked to launch the selection, and we also pass in the entire selection, not just one resource.
Marking as works for me.
