Comment 1 Szymon Brandys 2007-09-13 08:54:48 EDT

LinkedResourceTest#testLocationWithColon fails because of the patch for Bug 176703. 
Need to be reverted or fixed.

Comment 2 Szymon Brandys 2007-09-13 09:51:57 EDT

Are there any bad side effects (other than the failed test)?

Comment 3 John Arthorne 2007-09-13 10:32:50 EDT

Created attachment 78312 [details]
Proposed fix

Comment 4 John Arthorne 2007-09-13 10:45:50 EDT

There are two kinds of test failures:

1) LinkedResourceTest#testLocationWithColon on Linux and Mac. This is a bug in the implementation, and the attached patch in comment #3 is a proposed fix. This is a regression caused by the fix for bug 176703. 

2) IPathVariableTest failure on Mac.  This is caused by the fix for bug 202095.  WIth the fix, we are now converting path variable values to canonical form. This involves fixing the case of device ids, but also has the side-effect of resolving sym-links. It looks like by coincidence, the test was using the path /tmp/backup, and on the test machine /tmp is a sym-link. After the symlink is resolved, the test fails because the path variable value doesn't match the expected path. This is just a bug in the test, and the fix is to just use a path in the test that doesn't exist on the test machine (/blort/backup).

Comment 5 John Arthorne 2007-09-13 11:05:20 EDT

I have released a fix to the tests for problem 2).   We are now running tests on the patch in comment #3 for problem 1).

Comment 6 Szymon Brandys 2007-09-13 12:08:33 EDT

The stack trace when the patch is applied

junit.framework.AssertionFailedError: 1.0 expected:<c:/temp> but was:<c%3A/temp>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:280)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at org.eclipse.core.tests.resources.LinkedResourceTest.testLocationWithColon(LinkedResourceTest.java:1118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at junit.framework.TestCase.runTest(TestCase.java:164)
	at junit.framework.TestCase.runBare(TestCase.java:130)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:120)
	at junit.framework.TestSuite.runTest(TestSuite.java:230)
	at junit.framework.TestSuite.run(TestSuite.java:225)
	at junit.framework.TestSuite.runTest(TestSuite.java:230)
	at junit.framework.TestSuite.run(TestSuite.java:225)
	at junit.framework.TestSuite.runTest(TestSuite.java:230)
	at junit.framework.TestSuite.run(TestSuite.java:225)
	at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
	at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:58)
	at org.eclipse.pde.internal.junit.runtime.CoreTestApplication.run(CoreTestApplication.java:24)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethod(EclipseAppContainer.java:575)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:171)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:515)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:455)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1193)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1169)

Comment 7 John Arthorne 2007-09-14 22:17:26 EDT

Test fixed by reverting some of the changes from bug 176703.

Comment 8 Szymon Brandys 2007-09-18 11:17:46 EDT

Verified in I20070918-0010