Comment 1 Roberto Sanchez 2007-09-01 15:48:58 EDT

Hi, I got more info, this problem happens when I try to entry in my application with [Enter] key instead of clicking over [OK] button in Login Dialog.

I have a LoginDialog that appears before Workbench, when I login into application then I close Login dialog and launch Workbench, if login fails then I show a MessageDialog to user in this case all works fine.

If I "send" data clicking over [OK] Button the Workbench is loaded successfully but  If I press [Enter] after user/password are typed then appears the Javascript problem.

[OK] Button is setted as default shell button.

In firefox works fine.

I think that this problem is old, but now the problem is more obvious due to new Error management on client-side.

I'll try to get a snippet to reproduce it.

Cheers.
Roberto.

Comment 2 Roberto Sanchez 2007-09-01 16:03:07 EDT

A little more info:

It only fails if I press [Enter] from password text field, If a press it from user text box or in other control on dialog then all works.

All this info has no sense for me, I hope that you can see beyond.

Ciao.

Comment 3 Roberto Sanchez 2007-09-02 05:10:23 EDT

Hi friends, more info, I hope that this could be definitive.

The problem happens when password text box is disposed, but only if event is fired  pressing [Enter] when own password field is edited. 


An Entrypoint to reproduce it:

public class EntryPointTest implements IEntryPoint {

	public Text userName = null;
	public Text userPassword = null;
	
	public Display createUI() {
		
		Display d = new Display();
		Shell shell = new Shell( d, SWT.NONE | SWT.TITLE );
		
		shell.setSize(new Point(350, 200));
		shell.setLocation(300, 300);
		shell.setText("Javascript error in Internet Explorer 7");
		shell.setBackground( Graphics.getColor(250, 222, 150));
		
		shell.setLayout(new RowLayout(SWT.VERTICAL));

		Label info = new Label(shell, SWT.NONE);
		info.setText("Set user and password, then press [Enter] from password field");
		
		Group datos = new Group(shell, SWT.NONE);
		datos.setText("Login");


		GridLayout gridLayout2 = new GridLayout(2, false);
		datos.setLayout(gridLayout2);

		Label userNameLabel = new Label(datos, SWT.NONE);
		userNameLabel.setText("User:");
		userName = new Text(datos, SWT.BORDER | SWT.SINGLE);
		userName.setTextLimit(40); 		
		userName.forceFocus();
		GridDataFactory.swtDefaults().applyTo(userName);

		Label userPasswordLabel = new Label(datos, SWT.NONE);
		userPasswordLabel.setText("Password:");
		userPassword = new Text(datos, SWT.PASSWORD | SWT.BORDER| SWT.SINGLE );
		userPassword.setTextLimit(20);
		GridDataFactory.swtDefaults().applyTo(userPassword);
	
				
		Composite comp = new Composite(shell, SWT.NONE);

		comp.setLayout(new FillLayout());
		
		final Button loginButton = new Button( comp, SWT.PUSH | SWT.FLAT);
		loginButton.setText( "Default Button" );
		loginButton.getShell().setDefaultButton( loginButton );
		
		loginButton.addSelectionListener( new SelectionAdapter() {
			public void widgetSelected( final SelectionEvent event ) {

				
				EntryPointTest.this.userPassword.dispose();
				if (!EntryPointTest.this.userPassword.isFocusControl()) {
					MessageDialog.openInformation(Display.getCurrent().getActiveShell(), "Info", "No focus over password field then nothing happens, please refresh page manually.");
				}
			}
		});


		
		shell.layout();
		shell.open();
		
		
		return d;

	}


}

Comment 4 Rüdiger Herrmann 2007-09-03 03:08:22 EDT

Thanks for the hint and sorry for the inconvenience.
From what it looks like this is a qooxdoo bug that we applied a workaround for SINGLE text some days ago. Client-side SINGLE, MULTI and PASSWORD text are implemented differently.
I will try to apply the same workaround for PASSWORD and MULTI text.

Comment 5 Rüdiger Herrmann 2007-09-03 05:07:21 EDT

Created attachment 77576 [details]
Workaround that solves the problem

Attached a patch beforehand, changes will be committed to CVS this evening.

Comment 6 Roberto Sanchez 2007-09-03 05:20:56 EDT

Thank you Rüdiger for your quick answer, the patch works fine for me.

Ciao.
Roberto.

Comment 7 Rüdiger Herrmann 2007-09-03 12:02:20 EDT

Fixed in CVS HEAD