Community
Participate
Working Groups
While in active task, quick unfiltering (Alt-click) on the project node in the Package Explorer view don't show classpath containers
Just investigated. This is odd because the InterestFilter is not involved with determining whether that node should show, since all nodes given by the content provider should show when Alt+click is pressed. So I think that the Java content provider is doing some tricks with determining when that node should be shown, since ClassPathContainer nodes are not a model element and may not be shown if no dependencies are to be shown. Note that the Alt+click behavior works as expected for this case when using the Project Explorer. Martin: can you say off-hand if there is a rule in the Package Explorer to do something along the lines of suppressing showing the Plug-in Dependencies node if none of it's children are going to be shown?
I don't think it is a minor severity, because it doesn't allow to browse trough project dependencies. Also, I don't recall this in the old Eclipse, so it could be something introduced in one of the last 3.3 milestones.
Yes, the Plug-in Container is only shown if there's at least one non-filtered child.
Martin, would it be possible to replace this rule with a "visible" filter, that Mylyn can disable when needed?
*** Bug 201913 has been marked as a duplicate of this bug. ***
We added this to avoid that the container entries shows up alone when users filtered internal or/and external JARs. What's your suggestion exactly, Eugene?
(In reply to comment #6) > We added this to avoid that the container entries shows up alone when users > filtered internal or/and external JARs. > > What's your suggestion exactly, Eugene? I suggest to move that logic into a filter that can be disabled from view menu / Filters... Then Mylyn can disable this filter automatically when focus on task context is on, and enable it back when focus is switched off.
(In reply to comment #7) > I suggest to move that logic into a filter that can be disabled from view menu / > Filters... Then Mylyn can disable this filter automatically when focus on task > context is on, and enable it back when focus is switched off. -1. I don't think that a filter that's an implementation detail (decision to hide a node when nothing is in it) should be exposed to the user in this way. Martin: do you know off-hand what the difference is in the Package Explorer and Project Explorer's filtering/refresh policy with respect to filtering the Plug-in Dependencies container? I believe that they both avoid showing the container if there are none, so I'm a bit confused about why the node is not showing. In this scenario the Mylyn filter is always returning false for the select method so the expectation is that everything should be shown.
Only the package explorer tries to hide the referenced libraries and the classpath containers. (This is hardcoded in: org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart.PackageExplorerProblemTreeViewer.isFiltered(Object, Object, ViewerFilter[])) The project explorer always shows them. I'm not opposed to add a new filter 'Filter classpath containers'. The 'Referenced Libraries' node is trickier as this depends on two filter settings and if there are class folders in the project.
(In reply to comment #8) > -1. I don't think that a filter that's an implementation detail (decision to > hide a node when nothing is in it) should be exposed to the user in this way. Weird. I would say that filters are obvious candidates for hiding anything and they give much better visibility then hardcoded rules for hiding stuff
Martin, is there a chance that issue with "Referenced Libraries" and other empty classpath containers can be addressed in Eclipse 3.4? I.e. that rule converted to an explicitly visible filter? Mik, I've also noticed that "Package Explorer" view also don't show non-empty classpath containers when project is Alt-Clicked, which is practically forces user to turn off Mylyn filtering on the entire view if they need to browse trough any jars in that container. That includes "Plug-in Dependencies" and "JRE System Library" classpath containers. Not sure why this is happening, but it might as well be that "Package Explorer" rules on hiding empty containers is getting confused by Mylyn's own filtering.
I would need a bug in JDT/UI describing exactly what you expect us to add and how it should work.
(In reply to comment #12) > I would need a bug in JDT/UI describing exactly what you expect us to add and > how it should work. I created bug 219335 for that. Hope that helps.
Eugene: I assume that you only see the problem you state in comment#11 in the Package Explorer, and that it works as expected in the Project Explorer? I took a quick look and am wondering if this is just another instance of bug 219335 that you created.
Mik, looking at the FAQ entry you've just created I now wonder if Mylyn could disable "Show Referenced Libraries Node" when "focus on active task" in the Package Explorer is on? Though I still (In reply to comment #14) > Eugene: I assume that you only see the problem you state in comment#11 in the > Package Explorer, and that it works as expected in the Project Explorer? I took > a quick look and am wondering if this is just another instance of bug 219335 > that you created. Not sure what you mean by another instance and bug 219335 been created only to track things at JDT side as per Martin request. I am not using Project Explorer, so can't say if it has the same issue or not.
Need to defer: http://wiki.eclipse.org/index.php/Mylyn/3.0_Plan#Deferred_Items
Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn
