Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 199127 - [Commands] ContentAssistCommandAdapter#setEnabled(..) does not update handler activation
Summary: [Commands] ContentAssistCommandAdapter#setEnabled(..) does not update handler...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-07 13:27 EDT by Markus Keller CLA
Modified: 2009-10-29 11:38 EDT (History)
2 users (show)

See Also:

Attachments
Fix (4.33 KB, patch)
2009-05-01 16:33 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-08-07 13:27:15 EDT 
I20070807-0010

ContentAssistCommandAdapter#setEnabled(..) does not enable/disable the command handlers on the Mac.

To reproduce, open the Find/Replace dialog on a text editor and then toggle the Regular Expressions checkbox. The lightbulb on the find field is correctly added/removed, but the availability of Ctrl+Space to open the content assist proposals popup is only updated when the field has lost focus.

The problem is not reproducible on Windows, probably because the find field always loses focus on Windows when the checkbox is toggled.
Comment 1 Markus Keller CLA 2009-05-01 16:33:10 EDT 
Created attachment 134115 [details]
Fix

Note that the adapter is initially broken when the Find/Replace dialog is freshly created, see bug 274194.
Comment 2 Markus Keller CLA 2009-09-15 07:09:27 EDT 
Could you please release this patch? I almost filed a new bug...
Comment 3 Paul Webster CLA 2009-10-13 15:01:24 EDT 
Released to HEAD >20091013
PW
Comment 4 Oleg Besedin CLA 2009-10-29 11:38:43 EDT 
Verified in I20091027-0100.