Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 197513 - bugzilla-specific duplicate detector is missing kind attribute
Summary: bugzilla-specific duplicate detector is missing kind attribute
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 197181
Blocks:
  Show dependency tree
 
Reported: 2007-07-23 13:39 EDT by Eugene Kuleshov CLA
Modified: 2007-08-02 13:32 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (2.95 KB, application/octet-stream)
2007-07-30 01:36 EDT, Robert Elves CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2007-07-23 13:39:55 EDT 
According to the wiki [1] repository-specific duplicate detector should have kind attribute specified. However duplicate detector org.eclipse.mylyn.internal.bugzilla.ide.StackTraceDuplicateDetector which is using BugzillaRepositoryQuery internally is missing this attribute.

[1] http://wiki.eclipse.org/Mylyn_Integrator_Reference#Duplicate_Detectors
Comment 1 Mik Kersten CLA 2007-07-27 09:17:39 EDT 
Rob: I'm not sure that Meghan is doing any work on duplicate detectors, so this should happen after your other duplicate detector clean-up.
Comment 2 Eugene Kuleshov CLA 2007-07-27 10:32:35 EDT 
Since bug 197181 is more involved (and it doesn't seem like it having P1 or even P2 priority), I would recommend to fix this one first and then refactor bugzilla detector once connector-neutral search facility is in place.
Comment 3 Robert Elves CLA 2007-07-30 01:36:38 EDT 
Fixed.
Comment 4 Robert Elves CLA 2007-07-30 01:36:41 EDT 
Created attachment 74896 [details]
mylyn/context/zip
Comment 5 Eugene Kuleshov CLA 2007-07-30 11:35:54 EDT 
Rob, just add kind to plugin.xml isn't enough. You need to filter detectors by connector type in bugzilla task editors, otherwise they would show other detectors.
Comment 6 Robert Elves CLA 2007-07-30 15:43:39 EDT 
 (In reply to comment #5)
> Rob, just add kind to plugin.xml isn't enough. You need to filter detectors by
> connector type in bugzilla task editors, otherwise they would show other
> detectors.
Thanks. Done.
Comment 7 Eugene Kuleshov CLA 2007-08-01 21:47:07 EDT 
Still doesn't seem right. I think it should be: detector.getKind() == null || detector.getKind().equals(getConnector().getConnectorKind())
Comment 8 Robert Elves CLA 2007-08-02 13:21:28 EDT 
Thanks again. I had the wrong semantics in mind for getKind().
Comment 9 Eugene Kuleshov CLA 2007-08-02 13:32:03 EDT 
You are welcome. :-)

I am just interpreting Mik's description from the wiki [1], even so that description isn't really accurate. See my comment on the wiki.

[1] http://wiki.eclipse.org/Mylyn_Integrator_Reference#Duplicate_Detectors