Community
Participate
Working Groups
Cloned for consideration in 3.3.1 +++ This bug was initially created as a clone of Bug #195384 +++ When running "eclipsec.exe -vm C:/WINNT" (from a batch file, command line or via a shortcut; there is no difference), the launcher crashes with a memory violation (looks like a null pointer access), see 'crash-1.png'. When running "eclipsec.exe -vm C:\WINNT" (using a backslash), the launcher crashes, too. But this time with another error message (crash-2.png). In both cases, the launcher can impossibly find a JVM in the given directory, so the initial error was mine. But it should catch this error and provide a proper error message. By the way, a helpful message (something like "..A JRE must be available in C:...") pops up when I run "eclipsec.exe -vm C:\". I renamed eclipse.ini to make sure nothing there is causing the problem. Using eclipse.exe instead of the console launcher produces the same errors.
2 Problems here: 1) Finding the shared library should return null instead of a nonexistant file. 2) On windows, the adjustSearchPath needs to handle '/' path separators in addition to the normal '\'. (This can cause NPE with valid paths)
Created attachment 73584 [details] patch
Andrew and I think some restructuring could be done to separate some of the common code, but that can be done in 3.4. This patch is good and the change is minimal for 3.3.x.
done in 3.3.1
Andrew, why has this fix not been released to HEAD for bug 195384?
I think I was going to try and refactor the code as per comment #3 to get a nicer fix
