Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 196082 - Make 'Clear outgoing' action more accessible
Summary: Make 'Clear outgoing' action more accessible
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: 3.0   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 218704 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-07-10 17:49 EDT by Alex Blewitt CLA
Modified: 2008-02-19 16:50 EST (History)
3 users (show)

See Also:


Attachments
mylyn/context/zip (9.34 KB, application/octet-stream)
2008-02-12 19:07 EST, Mik Kersten CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2007-07-10 17:49:45 EDT
If I have a bug that I'm reporting changes in, and I do a 'submit', occasionally the connection dies. I'm then left with a bug which has a record of an outgoing change to that bug.

I tend to find in these cases that the change has gone through, it's just that the client hasn't got a successful response. If I synchronize, I can see my comment, but the outgoing change still shows up in the task list. There should ideally be some way of throwing away that change and not having the bug marked as outgoing, but synchronizing/closing/re-opening doesn't seem to do it.

In the end, I just erased the comments in the comment box, then clicked on 'submit', and fortunately the remote system ignored my empty comment. But it did fix the problem of the outgoing change. Not a great workaround, and presumably other back-end systems wouldn't be that intelligent in the case of an empty change, so it would be nice to have some kind of 'revert' on the task list context menu.
Comment 1 Steffen Pingel CLA 2007-07-10 18:07:21 EDT
Right-click the task in the task list and select Mark -> Clear outgoing from the context menu. The same action is also available from the editor context menu and should refresh the editor with all outgoing changes cleared after showing a confirmation dialog.

I have always found that it is hard to figure out how to to do that. Rob, could we put that action into the file menu also? 

Alex, do you have any suggestions where to put this? Where did you look first?
Comment 2 Alex Blewitt CLA 2007-07-10 18:14:08 EDT
That does exactly what I was looking for :-)

However, I wasn't expecting to find it in Mark, and hadn't thought to look there. I'd not seen it before (mostly because I've never thought to Mark Read or Mark Complete on a work-in-progress bug) and it's not an obvious 'mark' for me, whereas the complete/incomplete/read/unread are.

What about putting it on the main pop-up menu iff you're looking at a bug with outgoing changes? So, rather than disabling it when it's not allowed, having it not there at all? I don't think there's a big benefit in it taking up space when it can't be selected, although it would make it clearer what it is.

The other thing I noticed was that the File -> Revert menu is disabled when editing a bug report. I think this would be the kind of place a normal editor user might look, so wiring the 'revert' to the 'clear outgoing' might be a good move, too.


Comment 3 Robert Elves CLA 2007-07-13 14:32:26 EDT
 (In reply to comment #2)
> What about putting it on the main pop-up menu iff you're looking at a bug with
> outgoing changes? So, rather than disabling it when it's not allowed, having it
> not there at all? 
 
 This seems like a good idea to me. The current location of Clear Outgoing option is definitely not intuitive.
 
> The other thing I noticed was that the File -> Revert menu is disabled when
> editing a bug report. I think this would be the kind of place a normal editor
> user might look, so wiring the 'revert' to the 'clear outgoing' might be a good
> move, too.
This could be done as well.
Comment 4 Steffen Pingel CLA 2007-07-13 17:40:48 EDT
> > What about putting it on the main pop-up menu iff you're looking at a bug with
> > outgoing changes? So, rather than disabling it when it's not allowed, having
> it
> > not there at all?
> 
> This seems like a good idea to me. The current location of Clear Outgoing
> option is definitely not intuitive.

+1

> > The other thing I noticed was that the File -> Revert menu is disabled when
> > editing a bug report. I think this would be the kind of place a normal editor
> > user might look, so wiring the 'revert' to the 'clear outgoing' might be a
> good
> > move, too.
> This could be done as well.

Revert has a slightly different semantic though. It only reverts the changes since the last save so we should not reuse that menu item but maybe we could consider contributing an additional menu item.
Comment 5 Alex Blewitt CLA 2007-07-13 17:51:41 EDT
I think that revert would do in this case too ... it's basically undoing your last change. The difference in this case is that the revert isn't tied to the editor dirty cycle, but rather whether that change has been synchronized with the remote repository.
Comment 6 Mik Kersten CLA 2008-02-12 17:09:51 EST
*** Bug 218704 has been marked as a duplicate of this bug. ***
Comment 7 Mik Kersten CLA 2008-02-12 19:07:41 EST
Done.  We now have a Clear Outgoing action that shows up on the editor's toolbar when there are outgoing changes.
Comment 8 Mik Kersten CLA 2008-02-12 19:07:48 EST
Created attachment 89578 [details]
mylyn/context/zip
Comment 9 Mik Kersten CLA 2008-02-14 14:10:13 EST
Added support for clearing outgoing when there is a conflict.
Comment 10 Steffen Pingel CLA 2008-02-19 16:50:10 EST
Fixed enablement of action while submitting tasks.