This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 196032 - provide decoration for pending patches that require a review
Summary: provide decoration for pending patches that require a review
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 211011
  Show dependency tree
 
Reported: 2007-07-10 13:35 EDT by Steffen Pingel CLA
Modified: 2009-09-25 21:27 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2007-07-10 13:35:03 EDT 
Add a decoration to mark bug reports that have pending patches or need review.
Comment 1 Mik Kersten CLA 2007-07-10 17:55:33 EDT 
What should we make the API?  Here's a quick stab at it.
* AbstractRepositoryTask.getNeedsInput()
* UserInputRequest
   - String originatorId; // e.g. steffen.pingel@eclipse.org
   - String message;
Comment 2 Steffen Pingel CLA 2007-07-11 00:06:11 EDT 
I am not sure how to generalize this on a connector level. It seems mostly project, configuration or policy dependent how the criteria for bugs that need attention is defined.
Comment 3 Robert Elves CLA 2007-11-24 15:41:21 EST 
I believe the Bugzilla flags feature is used for this (at least on bugs.eclipse.org).  Unfortunately, flag support (bug#186265) is not going to happen any time soon.
Comment 4 Robert Elves CLA 2007-11-24 16:49:41 EST 
Upon further thought, we could add support for a review status field on RepositoryAttachment.  

	public enum REVIEW_STATUS {
		PENDING, ACCEPTED, REJECTED
	};
	
	REVIEW_STATUS reivewStatus;
	String reviewee;

Bugzilla connector could then pars the flags on attachments and set this field appropriately.  Of course this starts to introduce workflow that will be different depending on practices/connector....
Comment 5 Mik Kersten CLA 2009-08-13 20:01:29 EDT 
Mostly an internal Mylyn dev need.
Comment 6 Steffen Pingel CLA 2009-08-13 20:48:35 EDT 
We now use [patch] and [review] in task summaries as a convention to tag bugs that have pending patches attached.
Comment 7 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn