Community
Participate
Working Groups
This enhancement is required to streamline the user experience once bug 190802 and bug 179354 are resolved. After resolving these bugs, the "attach" operation may take 2-3 minutes on large applications (such as the Eclipse workbench), during which the profiled application will be frozen. It is therefore advisable to have a visual indication to the user that a work is in progress and that the system is not actually frozen.
The attach process should then be launch as a job so user can monitor the job in the Progress view and given a chance to cancel the job if necessary.
Created attachment 73298 [details] Proposed implementation Attach process implemented as standard workbench job.
Eugene, Thank you for suggestion. The attached was wrapped into standard scheduled job processing: the attach progress indication is shown in bottom right position on status bar of workbench. The message is: "Attaching to the JVMTI agent". Can you please review the proposed patch?
Ruslan, The patch looks good to me. However, there is new string (PII) change in the patch and it cannot be included for 4.4.0.1 point release. Guru, 4.4.0.1 cannot introduce any new PII string, would you please update the target to a release that accepts PII changes? or as a workaound, Ruslan, please try to reuse string that already exists.
Created attachment 73406 [details] Updated patch Reusing TIMessages.TASK_CONNECTING_TO_AGENT string (Connecting to the JVMTI agent) which actually has been used in similar conditions in TI launch code.
Eugene, Please review the last patch.
The latest patch looks good . Thanks!
The patch checked into CVS. No new strings were created.
During testing of my fixes to bug 190802 and bug 179354 I found that the implementation of this feature does not work correctly. When the user attaches, the workbench instantly switches the monitor status from "paused" to "active" regardless of the time it takes for the "attach" operation to be performed on the runtime side. I think this is related to the asynchronous nature of the Agent Controller commands interface. The call to the attach/run command of the execution framework probably returns instantly, even when the processing of this command on the runtime side was not yet completed. Maybe we need to use a different approach: After sending the "run" command to the Agent Controller, wait for a "attach completed" notification from the runtime, and only then update the status of the monitor in the UI. Re-opening this defect.
Ruslan is not available for the changes. Alexander - roll this work into the Auto-attach work you are currently focusing on.
Mass update of P1 enhancements and defects targetted to future to P2.
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As such, TPTP is not delivering enhancements. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement is resolved as WONTFIX. For this enhancement to be considered, please re-open with an attached patch including the Description Document (see http://www.eclipse.org/tptp/home/documents/process/development/description_documents.html), code (see http://www.eclipse.org/tptp/home/documents/resources/TPTPDevGuide.htm), and test cases (see http://www.eclipse.org/tptp/home/documents/process/TPTP_Testing_Strategy.html).
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
