Community
Participate
Working Groups
Need shortcuts for all test navigator pulldowns (eg right click on test or schedule and not all menu items have shortcuts)
Jerome, we should also verify that all of the Test widgets have shortcuts.
Reference: http://wiki.eclipse.org/index.php/Platform_Command_Framework
Created attachment 76465 [details] Partial patch Partial patch. Outstanding: 1) Externalize strings in extension point implementations to plugin.properties. There is an opportunity to reuse existing strings. 2) Implement the org.eclipse.ui.handlers extension point to provide conditions for activating and enabling the handler associated with commands. 2) Implement the org.eclipse.ui.contexts extension point to provide a context for commands related to the Test Perspective. For example, <extension point="org.eclipse.ui.contexts"> <context name="In Test Perspective" description="Test Perspective context." id="org.eclipse.hyades.test.ui.internal.perspective.context"> </context> </extension> Note, this would change the contextId attribute of the key elements in the org.eclipse.ui.bindings extension point implementation to 'org.eclipse.hyades.test.ui.internal.perspective.context'. 4) Create shortcuts for all drop-downs, context menus, popups in the Test Navigator.
Updated hours worked.
Transferring to Jerome to complete patch.
Deferred to 4.5 due to lack of resources and PII changes. Jerome, we will need to adjust the sizing given they amount of work required for this defect. Also, we will need document these shortcuts in the Test Project documentation.
*** Bug 205470 has been marked as a duplicate of this bug. ***
Bulk update of the target field to reflect the change in iteration numbers.
Any advantage to checking in the partial patch as part of i6?
(In reply to comment #9) > Any advantage to checking in the partial patch as part of i6? > No, this partial patch was an incomplete first pass.
Reassigning to Tony to be completed in I7.
Deferring to I7 as discussed by PMC/AG (http://wiki.eclipse.org/TPTP-AG-20080331#Test_Project).
Created attachment 96727 [details] Partial patch(all underline shortcut) This is the partial patch about all underline shortcuts.. and i'm still working on the right-click context menu
Deferring to future as approved by the TPTP PMC (http://dev.eclipse.org/mhonarc/lists/tptp-pmc/msg04926.html).
Hi Paul, Could you please look at attached Partial patch2 and handle the contest menu part? Thanks! For those buttons and windows in test viewer and wizards, i tried my best to give them different shortcuts. since we only have a-z to choose, they still have three conflicts, so i changed them with adding a dot after its string to let "&." as a shortcut... There are two kind of buttons that haven't solved yet: 1. Add/remove/up/down/open list in deployment pair page The buttons are created in /org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/editor/form/ArtifactLocationMapForm.java and the string are called in some method(i.e MoveFeatureChildrenUpAction), so if we want to separate those shortcuts, i tried to create some new methods but it's not good enough, it takes could you find a better way to separate that? 2. "More..." button in overview page The buttons are created in /org.eclipse.hyades.test.tools.ui/src/org/eclipse/hyades/test/tools/ui/common/internal/editor/OverviewEclipseForm.java UiPluginResourceBundle.ACT_MORE most of the time, there is only one More button in overview page, it seems like the overview page set ACT_MORE as default as long as the More button is added.. In all tests and Test assets, Deployment and Artifact have more than one More button. Thanks a lot!
Created attachment 107768 [details] Partial patch2
There will be duplicate shortcuts on the Up/Down buttons (Artifact Location Pairs pane of the Paris page in the Deployment editor) since there are not enough unique characters, without changing the button labels. Users can tab to these buttons or select the artifact/artifact location pair before selecting the shortcut key for the Up/Down button.
Created attachment 108118 [details] Patch Part 1.
Hours worked to create/test patch (part 1). Patch (part 1) checked in to CVS (HEAD).
Created attachment 108246 [details] Patch Part 2. Patch (Part 2) checked in to CVS (HEAD).
Deferring to 4.5.2.
(In reply to comment #19) > Patch (part 1) checked in to CVS (HEAD). (In reply to comment #20) > Patch (Part 2) checked in to CVS (HEAD). These patches (Part 1 and Part 2) have been backed out of CVS (HEAD)/TPTP 4.5.1 since they contain new strings and TPTP 4.5.1 will not by translated by the consuming product. Since this defect requires new strings requiring translation, deferring to the next release of TPTP that will be translated (4.5.3).
Created attachment 109443 [details] Patch Part 3.
Revising sizing.
Decreasing priority to P2 since TPTP 4.5.3 defect plan has not been finalized.
Approved for the TPTP 4.5.3 defect plan (see PMC minutes from 02/25/09).
Please note that this defect fix is requested by an adopter product.
Created attachment 131150 [details] Patch Part 4.
Created attachment 132155 [details] Patch. This patch includes the follow patches: Patch Part 1. Patch Part 2. Patch Part 3. Patch Part 4. In addition, it includes the remaining shortcuts (excluding the Test Navigator context menu shortcuts). The attached patch checked into CVS (HEAD).
Hours worked to create the patch: 6 PH
Created attachment 133035 [details] Patch Part 2. This patch includes the follow: -Renaming shortcuts/key bindings for the context menus in the Test Navigator. -Support for open test assets in the Test Navigator with the F3 key. -Resolved an issue with the first patch removing several labels for datapool editor buttons. -Removed unused strings to reduce translation costs. The attached patch checked into CVS (HEAD). Outstanding: -Test cases for the shortcuts/key bindings for the context menus in the Test Navigator. -Documentation for the shortcuts/key bindings for the context menus in the Test Navigator.
Hours worked to create patch #2.
Note, the patch part 2 replaces the several implementations of the org.eclipse.ui.popupMenus extension point with implementations of the org.eclipse.ui.menus extension point (see the plugin.xml in org.eclipse.hyades.test.ui and org.eclipse.hyades.test.tools.ui) for the context menus in the Test Navigator.
Created attachment 133062 [details] Datapool SS (In reply to comment #31) > This patch includes the follow: > > -Resolved an issue with the first patch removing several labels for datapool > editor buttons. > Thanks Paul, the SS attached is the problem noted above, will verify when the build containing this fix comes out.
Created attachment 133796 [details] Patch Part 3.
The attached patch 3 contains the documentation for the shortcuts/key bindings for the context menus in the Test Navigator. The attached patch 3 checked in to CVS (HEAD).
New test suite (/org.eclipse.hyades.test.ui.navigator.tests/manual/Test.UI.TestNavigator_bugzilla_195203.testsuite) with 11 new test cases checked in to CVS (HEAD) and added to http://wiki.eclipse.org/TPTP_Test_Tools_Project_Tests#Manual for the shortcuts/key bindings for the context menus in the Test Navigator.
closing