Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 195203 - Accessibility-Need shortcuts for all Test Navigator pulldowns
Summary: Accessibility-Need shortcuts for all Test Navigator pulldowns
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact:
URL:
Whiteboard: adopter
Keywords:
: 205470 (view as bug list)
Depends on: 241804
Blocks: 284747
  Show dependency tree
 
Reported: 2007-07-02 22:24 EDT by Ashish Patel CLA
Modified: 2016-05-05 10:31 EDT (History)
4 users (show)

See Also:


Attachments
Partial patch (7.69 KB, patch)
2007-08-20 12:46 EDT, Paul Slauenwhite CLA
no flags Details | Diff
Partial patch(all underline shortcut) (74.05 KB, patch)
2008-04-19 21:54 EDT, Tony Wang CLA
no flags Details | Diff
Partial patch2 (33.00 KB, text/plain)
2008-07-17 15:22 EDT, Tony Wang CLA
no flags Details
Patch Part 1. (55.50 KB, patch)
2008-07-22 15:10 EDT, Paul Slauenwhite CLA
no flags Details | Diff
Patch Part 2. (4.88 KB, patch)
2008-07-23 14:29 EDT, Paul Slauenwhite CLA
no flags Details | Diff
Patch Part 3. (4.36 KB, patch)
2008-08-07 14:57 EDT, Paul Slauenwhite CLA
no flags Details | Diff
Patch Part 4. (5.60 KB, patch)
2009-04-07 13:09 EDT, Paul Slauenwhite CLA
no flags Details | Diff
Patch. (82.98 KB, text/plain)
2009-04-16 20:48 EDT, Paul Slauenwhite CLA
no flags Details
Patch Part 2. (105.57 KB, text/plain)
2009-04-23 18:21 EDT, Paul Slauenwhite CLA
no flags Details
Datapool SS (25.88 KB, image/jpeg)
2009-04-24 02:14 EDT, Ben Chen CLA
no flags Details
Patch Part 3. (18.35 KB, patch)
2009-04-29 13:07 EDT, Paul Slauenwhite CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ashish Patel CLA 2007-07-02 22:24:44 EDT
Need shortcuts for all test navigator pulldowns (eg right click on test or schedule and not all menu items have shortcuts)
Comment 1 Paul Slauenwhite CLA 2007-07-04 08:07:46 EDT
Jerome, we should also verify that all of the Test widgets have shortcuts.
Comment 2 Paul Slauenwhite CLA 2007-08-15 15:28:00 EDT
Reference: http://wiki.eclipse.org/index.php/Platform_Command_Framework
Comment 3 Paul Slauenwhite CLA 2007-08-20 12:46:48 EDT
Created attachment 76465 [details]
Partial patch

Partial patch.  

Outstanding:

1) Externalize strings in extension point implementations to plugin.properties.  There is an opportunity to reuse existing strings. 

2) Implement the org.eclipse.ui.handlers extension point to provide conditions for activating and enabling the handler associated with commands.   

2) Implement the org.eclipse.ui.contexts extension point to provide a context for commands related to the Test Perspective.  For example,

   <extension
   		 point="org.eclipse.ui.contexts">
   	  <context
   	  		name="In Test Perspective"
   			description="Test Perspective context."
            id="org.eclipse.hyades.test.ui.internal.perspective.context">
      </context>
   </extension>

Note, this would change the contextId attribute of the key elements in the org.eclipse.ui.bindings extension point implementation to 'org.eclipse.hyades.test.ui.internal.perspective.context'.

4) Create shortcuts for all drop-downs, context menus, popups in the Test Navigator.
Comment 4 Paul Slauenwhite CLA 2007-08-20 12:47:11 EDT
Updated hours worked.
Comment 5 Paul Slauenwhite CLA 2007-08-20 12:47:56 EDT
Transferring to Jerome to complete patch.
Comment 6 Paul Slauenwhite CLA 2007-08-27 10:42:37 EDT
Deferred to 4.5 due to lack of resources and PII changes.

Jerome, we will need to adjust the sizing given they amount of work required for this defect.  

Also, we will need document these shortcuts in the Test Project documentation.
Comment 7 Paul Slauenwhite CLA 2007-10-04 13:21:22 EDT
*** Bug 205470 has been marked as a duplicate of this bug. ***
Comment 8 Paul Slauenwhite CLA 2007-11-07 06:33:22 EST
Bulk update of the target field to reflect the change in iteration numbers.
Comment 9 jkubasta CLA 2008-03-19 21:06:19 EDT
Any advantage to checking in the partial patch as part of i6?
Comment 10 Paul Slauenwhite CLA 2008-03-26 06:24:47 EDT
(In reply to comment #9)
> Any advantage to checking in the partial patch as part of i6?
> 

No, this partial patch was an incomplete first pass.
Comment 11 Paul Slauenwhite CLA 2008-03-31 09:41:09 EDT
Reassigning to Tony to be completed in I7.
Comment 12 Paul Slauenwhite CLA 2008-03-31 12:14:25 EDT
Deferring to I7 as discussed by PMC/AG (http://wiki.eclipse.org/TPTP-AG-20080331#Test_Project).
Comment 13 Tony Wang CLA 2008-04-19 21:54:20 EDT
Created attachment 96727 [details]
Partial patch(all underline shortcut)

This is the partial patch about all underline shortcuts.. and i'm still working on the right-click context menu
Comment 14 Paul Slauenwhite CLA 2008-05-21 14:27:22 EDT
Deferring to future as approved by the TPTP PMC (http://dev.eclipse.org/mhonarc/lists/tptp-pmc/msg04926.html).
Comment 15 Tony Wang CLA 2008-07-17 15:21:50 EDT
Hi Paul, Could you please look at attached Partial patch2 and handle the contest menu part? Thanks!

For those buttons and windows in test viewer and wizards, i tried my best to give them different shortcuts. since we only have a-z to choose, they still have three conflicts, so i changed them with adding a dot after its string to let "&." as a shortcut...

There are two kind of buttons that haven't solved yet:
1. Add/remove/up/down/open list in deployment pair page
   The buttons are created in 
/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/editor/form/ArtifactLocationMapForm.java 
and the string are called in some method(i.e MoveFeatureChildrenUpAction), so if we want to separate those shortcuts, i tried to create some new methods but it's not good enough, it takes  could you find a better way to separate that?

2. "More..."  button in overview page
   The buttons are created in 
/org.eclipse.hyades.test.tools.ui/src/org/eclipse/hyades/test/tools/ui/common/internal/editor/OverviewEclipseForm.java
UiPluginResourceBundle.ACT_MORE
most of the time, there is only one More button in overview page, it seems like the overview page set ACT_MORE as default as long as the More button is added..
In all tests and Test assets, Deployment and Artifact have more than one More button.

Thanks a lot!
Comment 16 Tony Wang CLA 2008-07-17 15:22:04 EDT
Created attachment 107768 [details]
Partial patch2
Comment 17 Paul Slauenwhite CLA 2008-07-22 14:19:02 EDT
There will be duplicate shortcuts on the Up/Down buttons (Artifact Location Pairs pane of the Paris page in the Deployment editor) since there are not enough unique characters, without changing the button labels.  Users can tab to these buttons or select the artifact/artifact location pair before selecting the shortcut key for the Up/Down button.
Comment 18 Paul Slauenwhite CLA 2008-07-22 15:10:21 EDT
Created attachment 108118 [details]
Patch Part 1.
Comment 19 Paul Slauenwhite CLA 2008-07-22 15:10:58 EDT
Hours worked to create/test patch (part 1).

Patch (part 1) checked in to CVS (HEAD).
Comment 20 Paul Slauenwhite CLA 2008-07-23 14:29:48 EDT
Created attachment 108246 [details]
Patch Part 2.

Patch (Part 2) checked in to CVS (HEAD).
Comment 21 Paul Slauenwhite CLA 2008-07-29 09:49:07 EDT
Deferring to 4.5.2.
Comment 22 Paul Slauenwhite CLA 2008-08-07 14:57:35 EDT
(In reply to comment #19)

> Patch (part 1) checked in to CVS (HEAD).


(In reply to comment #20)

> Patch (Part 2) checked in to CVS (HEAD).

These patches (Part 1 and Part 2) have been backed out of CVS (HEAD)/TPTP 4.5.1 since they contain new strings and TPTP 4.5.1 will not by translated by the consuming product.  Since this defect requires new strings requiring translation, deferring to the next release of TPTP that will be translated (4.5.3).
Comment 23 Paul Slauenwhite CLA 2008-08-07 14:57:45 EDT
Created attachment 109443 [details]
Patch Part 3.
Comment 24 Paul Slauenwhite CLA 2008-09-22 09:39:52 EDT
Revising sizing.
Comment 25 Paul Slauenwhite CLA 2009-02-09 08:23:27 EST
Decreasing priority to P2 since TPTP 4.5.3 defect plan has not been finalized.
Comment 26 Paul Slauenwhite CLA 2009-02-25 10:59:05 EST
Approved for the TPTP 4.5.3 defect plan (see PMC minutes from 02/25/09).
Comment 27 Kathy Chan CLA 2009-04-03 15:00:00 EDT
Please note that this defect fix is requested by an adopter product.
Comment 28 Paul Slauenwhite CLA 2009-04-07 13:09:07 EDT
Created attachment 131150 [details]
Patch Part 4.
Comment 29 Paul Slauenwhite CLA 2009-04-16 20:48:26 EDT
Created attachment 132155 [details]
Patch.

This patch includes the follow patches: 

Patch Part 1.
Patch Part 2.
Patch Part 3.
Patch Part 4.

In addition, it includes the remaining shortcuts (excluding the Test Navigator context menu shortcuts).

The attached patch checked into CVS (HEAD).
Comment 30 Paul Slauenwhite CLA 2009-04-16 20:49:14 EDT
Hours worked to create the patch: 6 PH
Comment 31 Paul Slauenwhite CLA 2009-04-23 18:21:20 EDT
Created attachment 133035 [details]
Patch Part 2.

This patch includes the follow:

-Renaming shortcuts/key bindings for the context menus in the Test Navigator.
-Support for open test assets in the Test Navigator with the F3 key.
-Resolved an issue with the first patch removing several labels for datapool editor buttons.
-Removed unused strings to reduce translation costs.

The attached patch checked into CVS (HEAD).

Outstanding:

-Test cases for the shortcuts/key bindings for the context menus in the Test Navigator.
-Documentation for the shortcuts/key bindings for the context menus in the Test Navigator.
Comment 32 Paul Slauenwhite CLA 2009-04-23 18:43:18 EDT
Hours worked to create patch #2.
Comment 33 Paul Slauenwhite CLA 2009-04-23 18:49:18 EDT
Note, the patch part 2 replaces the several implementations of the org.eclipse.ui.popupMenus extension point with implementations of the org.eclipse.ui.menus extension point (see the plugin.xml in org.eclipse.hyades.test.ui and org.eclipse.hyades.test.tools.ui) for the context menus in the Test Navigator.
Comment 34 Ben Chen CLA 2009-04-24 02:14:14 EDT
Created attachment 133062 [details]
Datapool SS

(In reply to comment #31)
> This patch includes the follow:
> 
> -Resolved an issue with the first patch removing several labels for datapool
> editor buttons.
> 

Thanks Paul, the SS attached is the problem noted above, will verify when the build containing this fix comes out.
Comment 35 Paul Slauenwhite CLA 2009-04-29 13:07:19 EDT
Created attachment 133796 [details]
Patch Part 3.
Comment 36 Paul Slauenwhite CLA 2009-04-29 13:09:50 EDT
The attached patch 3 contains the documentation for the shortcuts/key bindings for the context menus in the Test Navigator.  

The attached patch 3 checked in to CVS (HEAD).
Comment 37 Paul Slauenwhite CLA 2009-04-29 15:27:52 EDT
New test suite (/org.eclipse.hyades.test.ui.navigator.tests/manual/Test.UI.TestNavigator_bugzilla_195203.testsuite) with 11 new test cases checked in to CVS (HEAD) and added to http://wiki.eclipse.org/TPTP_Test_Tools_Project_Tests#Manual for the shortcuts/key bindings for the context menus in the Test
Navigator.
Comment 38 jkubasta CLA 2009-05-26 13:33:43 EDT
closing