Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 194503 - Serviceability: Improve error handling and reporting in ASF adapters/services.
Summary: Serviceability: Improve error handling and reporting in ASF adapters/services.
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact:
URL:
Whiteboard: closed471
Keywords:
: 146678 210292 217487 (view as bug list)
Depends on: 178595
Blocks: 211751 296255
  Show dependency tree
 
Reported: 2007-06-26 16:40 EDT by Joe Toomey CLA
Modified: 2016-05-05 10:50 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Toomey CLA 2007-06-26 16:40:31 EDT
ASF has a lot of useful features and works great if you use it correctly. However, it's all too easy to miss a required parameter to a service or specify something else incorrectly.  If you do this, ASF services tend to throw uncaught exceptions, leaving the user with nothing but a confusing stack trace.  We also have several uncaught exceptions in the client adapters themselves.  We need to be much more polite.

I'll attach some examples of usage that causes the problems.  Each of these needs to be fixed.
Comment 1 Joe Toomey CLA 2007-06-26 16:43:29 EDT
1) If AC is not running on target remote machine:

[tptp:execution] org.eclipse.core.runtime.CoreException: IWAT4039E The Test Execution Harness reported the following problems:IWAT0016E The Agent Controller is not available on host wus-jtoomey03.
[tptp:execution]  Make sure that:
[tptp:execution] * the Agent Controller is installed.
[tptp:execution] * the Agent Controller is configured to communicate with your machine.
[tptp:execution] * you have the correct host name and port number for the Agent Controller.
[tptp:execution] 	at org.eclipse.hyades.test.core.launch.delegates.AbstractLaunchConfigurationDelegate2.launch(AbstractLaunchConfigurationDelegate2.java:195)
[tptp:execution] 	at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:766)
[tptp:execution] 	at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:608)
[tptp:execution] 	at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:601)
[tptp:execution] 	at org.eclipse.hyades.test.core.services.AbstractTestExecutionService.launch(AbstractTestExecutionService.java:807)
[tptp:execution] 	at org.eclipse.hyades.test.core.services.AbstractTestExecutionService.execute(AbstractTestExecutionService.java:588)
[tptp:execution] 	at org.eclipse.hyades.automation.server.AbstractService.execute(AbstractService.java:43)
[tptp:execution] 	at org.eclipse.hyades.automation.server.ServiceProxy$1.run(ServiceProxy.java:141)
[tptp:execution] 	at org.eclipse.hyades.automation.core.utils.ReusableThread.run(ReusableThread.java:131)
[tptp:execution] 	at java.lang.Thread.run(Unknown Source)

2) If service is not found in eclipse (line 100)

3) If test runner dies (no AutoUI plugins installed), seems to hang (does it time out eventually with inactive process exception?)

4) Assumptions about input paths starting with project name 

org.eclipse.hyades.test.core.services.AbstractTestExecutionService.getProjectFromWorkspaceRelativePath(String)

5) Pass in a test suite with no project

		<tptp:execution resultsrefid="test.results">
			<filelist dir="C:\TPTP_TestPass\4.4GA1\testprojects\test-results\test" 

files="org.eclipse.tptp.test.testservices.tests/junit/Test.IBM142_TestServices.testsuite"/>
		</tptp:execution>

[tptp:execution] java.lang.NullPointerException
[tptp:execution] 	at org.eclipse.hyades.test.core.services.AbstractTestExecutionService.loadModelElement(AbstractTestExecutionService.java:828)
[tptp:execution] 	at org.eclipse.hyades.test.core.services.AbstractTestExecutionService.loadTestSuite(AbstractTestExecutionService.java:853)
[tptp:execution] 	at org.eclipse.hyades.test.core.services.AbstractTestExecutionService.beforeLaunch(AbstractTestExecutionService.java:288)
[tptp:execution] 	at org.eclipse.hyades.test.core.services.AbstractTestExecutionService.execute(AbstractTestExecutionService.java:581)

Comment 2 Joe Toomey CLA 2007-08-24 15:22:21 EDT
Can't contain this in 4.4.1.  Deferring to 4.5
Comment 3 DuWayne Morris CLA 2007-11-28 09:31:13 EST
Setting target iteration.
Comment 4 DuWayne Morris CLA 2008-01-04 15:24:02 EST
Consumming product has requested increased priority on this one.  In this case, it is an occassional confusing error message about a missing memento-out.dat file.  This means an uncaught exception has caused the headless eclipse process to exit before ASF has written the output file.

There is a great need to improve error handling in a more robust manner in order to provide more informative messages.

Adjusting target to 4.5i5.  I intend to choose another defect that is currently scheduled to i5 and re-target to i6 if it looks like the schedule is running short.
Comment 5 Paul Slauenwhite CLA 2008-01-30 12:13:40 EST
Deferred from I5 to I6 with PMC approval.
Comment 6 Paul Slauenwhite CLA 2008-05-21 14:11:29 EDT
Deferring to future as approved by the TPTP PMC (http://dev.eclipse.org/mhonarc/lists/tptp-pmc/msg04926.html).
Comment 7 Paul Slauenwhite CLA 2009-11-23 08:15:17 EST
In addition:

6) Missing required properties.  For example, all adapters require a project (see #5), but fail quietly when the required properties are not provided (see the call to org.eclipse.hyades.automation.client.adapters.java.AutomationClientAdapter.checkProjectProperty(Properties) from org.eclipse.hyades.automation.client.adapters.java.AutomationClientAdapter.execute(String, Properties)).

Required to reduce the debugging effort for the TPTP BVTs.
Comment 8 Paul Slauenwhite CLA 2009-11-23 08:21:42 EST
Requires a 'trace' property (e.g. tptp.automation.trace=true or tptp.automation.vmargs=-Dtptp.automation.trace=true - preference is for the first one) to turn on execution-level tracing and output trace message to the console.  Documentation is required for this new property.
Comment 9 Paul Slauenwhite CLA 2009-11-23 08:23:58 EST
*** Bug 217487 has been marked as a duplicate of this bug. ***
Comment 10 Paul Slauenwhite CLA 2009-11-23 08:24:39 EST
*** Bug 210292 has been marked as a duplicate of this bug. ***
Comment 11 Paul Slauenwhite CLA 2009-11-23 08:26:17 EST
Requires resolving the issues in the following duplicate defects:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=217487
https://bugs.eclipse.org/bugs/show_bug.cgi?id=210292
Comment 12 Paul Slauenwhite CLA 2009-11-23 10:55:48 EST
(In reply to comment #7)
> In addition:
> 
> 6) Missing required properties.  For example, all adapters require a project
> (see #5), but fail quietly when the required properties are not provided (see
> the call to
> org.eclipse.hyades.automation.client.adapters.java.AutomationClientAdapter.checkProjectProperty(Properties)
> from
> org.eclipse.hyades.automation.client.adapters.java.AutomationClientAdapter.execute(String,
> Properties)).
> 
> Required to reduce the debugging effort for the TPTP BVTs.

Note, the following rules apply:

1) If the service implementation extends org.eclipse.hyades.test.core.services.AbstractAgentControllerVerificationService, the following properties are required:

connection

2) If the service implementation extends org.eclipse.hyades.automation.server.AbstractWorkspaceSensitiveService, the following properties are required:

workspace

3) If the service implementation extends org.eclipse.hyades.automation.server.AbstractProjectSensitiveService, the following properties are required:

project

Each adapter/service should be documented including their required/optional properties.
Comment 13 Paul Slauenwhite CLA 2009-11-26 14:33:51 EST
*** Bug 146678 has been marked as a duplicate of this bug. ***
Comment 14 Paul Slauenwhite CLA 2009-11-26 14:34:23 EST
Requires solution for the symptoms in https://bugs.eclipse.org/bugs/show_bug.cgi?id=146678.

Requires documentation/new error messages, which require translation.
Comment 15 Paul Slauenwhite CLA 2009-11-26 14:59:07 EST
Defect 296286 will cover documentation updates for ASF properties.  This defect will address the error handling/reporting and related error messages (requires translation).
Comment 16 Paul Slauenwhite CLA 2009-11-27 14:30:54 EST
Also, externalize any existing non-externalized ASF error messages and/or strings.
Comment 17 Paul Slauenwhite CLA 2010-03-10 12:20:53 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 18 Kathy Chan CLA 2010-11-18 18:55:15 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.