Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 194224 - [ui] User nicknames for repositories
Summary: [ui] User nicknames for repositories
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal with 3 votes (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 240797 245242 256219 265592 (view as bug list)
Depends on: 259598
Blocks: 198706
  Show dependency tree
 
Reported: 2007-06-25 11:08 EDT by Pascal Rapicault CLA
Modified: 2009-02-26 18:12 EST (History)
12 users (show)

See Also:


Attachments
work in progress (69.05 KB, patch)
2009-02-26 16:31 EST, Susan McCourt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2007-06-25 11:08:50 EDT
Repository managers should support for a user readable name to be associated with each repositories. This name should not be made mandatory.
Also it may be interesting to have repositories provide a name for themselves.
Comment 1 Susan McCourt CLA 2007-07-09 14:39:15 EDT
+1.
Right now all I can show in the UI is the URL and this is not very friendly for the simple user scenarios.  And I don't think it should be mapped at the user level since a repo may want to name itself (as Pascal mentioned).
Comment 2 Jeff McAffer CLA 2007-07-15 08:33:19 EDT
Just to clarify, we are suggesting that repos may define a name for themselves and that users may define a name for a repo.  This makes sense to me.  I assume that the user-defined name overrides the repo-defined name?
Comment 3 Susan McCourt CLA 2007-08-13 18:56:41 EDT
Dave has defined the name at the repo level. 
I won't worry about a user-defined name that overrides the producer's name until I am working on the exact use case.
Comment 4 Jeff McAffer CLA 2007-09-17 16:22:01 EDT
Note sure what is happening here.  Currently the repos we create in the code all have names etc.  The names might not be that great but all the repo creation API allows for the name to be spec'd.  What more is needed?
Comment 5 Susan McCourt CLA 2007-09-17 17:38:52 EDT
I left this bug open because there was talk of a name that the user could override (see comment #2). 

If the repo is not writable the user can't (and shouldn't) be setting its name.  No one but the repo producer should set its name, but we may want to allow users to give it their own name.

I'll tag this as a UI bug.
Comment 6 Susan McCourt CLA 2007-09-24 11:40:21 EDT
renaming to address remaining point
Comment 7 Eugene Kuleshov CLA 2008-04-01 16:43:05 EDT
I am not familiar with p2 intrnal, but from the end user point of view it would be really useful to be able to name repositories created for classic update sites.
Comment 8 Susan McCourt CLA 2008-04-01 18:00:07 EDT
marking 3.4 so we can consider this
Comment 9 Mik Kersten CLA 2008-04-01 18:47:59 EDT
+1 for providing grouping by either specified site name or nickname.  To date plug-in vendors have not had to name categories in a way that makes sense independently of the update site.  For example, Mylyn's categories, spread across two different update sites, are:

Features
Feedback
Integration
Integration

The result doesn't make much sense (see bug 225004) so as a temporary workaround Mylyn is in the process of prefixing all category names with "Mylyn -" and changing them to be globally unique.
Comment 10 Susan McCourt CLA 2008-04-21 16:24:24 EDT
When this is implemented, we would want to expand the import/export support in bug #224999 to read and write the name.
Comment 11 Susan McCourt CLA 2008-04-29 16:25:06 EDT
(This message is part of a bulk bug update.)
Removing milestone.
We are feature frozen for 3.4.
These were good ideas but are simply out of time and need to focus on stability.
Comment 12 Ian Bull CLA 2008-05-21 02:22:15 EDT
A related issue:

I added http://downlaod.eclipse.org/eclipse/testUpdates to my list of sites, and in my list of available software, this site was listed.

Then, after a restart of Eclipse, the name of the site changes to: file:/builds/I2008.....yada yada/src/repo

now I assume that some local caching of the test update site happened, but this was a little confusing.  Do you think we can keep the name of the original site?

Comment 13 John Arthorne CLA 2008-05-21 10:20:15 EDT
Re comment #12 - see bug 230322
Comment 14 Susan McCourt CLA 2008-05-21 11:29:36 EDT
Weren't we going to fix the problem where the actual repo name (file:/builds/I2008.....yada yada/src/repo) was so ugly?  I looked for the relevant bug but can't find it... 
Comment 15 DJ Houghton CLA 2008-05-21 11:38:28 EDT
Susan: see bug 231215.
Comment 16 Susan McCourt CLA 2008-05-21 13:34:46 EDT
thanks, DJ, I annotated that bug because I still see the weird name in the I20080520 repo.

Back to the topic of the bug...marking this 3.5 because there's been a lot of support for user naming, and in fact it's seen as a regression by UM users.
Comment 17 John Arthorne CLA 2008-07-15 12:36:34 EDT
*** Bug 240797 has been marked as a duplicate of this bug. ***
Comment 18 Jeremy CLA 2008-07-29 12:29:30 EDT
"it's seen as a regression by UM users"

There's no "seen as" about it: in Europa you could set repository names when you added them, in Ganymede you can't.  When a new version of software can't do what an older version can, that's not "seen as" a regression, it IS a regression.

To be honest, I don't why anyone would make this regression; why remove something (the repository name textbox in the add repository dialog) that nobody complains about and in fact many people use?
Comment 19 John Arthorne CLA 2008-08-27 15:39:53 EDT
*** Bug 245242 has been marked as a duplicate of this bug. ***
Comment 20 Susan McCourt CLA 2008-11-24 11:17:40 EST
*** Bug 256219 has been marked as a duplicate of this bug. ***
Comment 21 Susan McCourt CLA 2008-12-23 15:09:30 EST
What I can do today (well, for M5...) is the following:

- UI uses the repo manager name property to get the name as it does today
- UI sets this property in the manager when it adds a repo  (User has a name field in the add repo dialog and could possibly edit the name in the repo pref page).

Until bug 259598 is implemented, the problem is that the user name would be overridden by the producer's name when the repo was loaded.
Comment 22 Susan McCourt CLA 2009-01-19 13:56:07 EST
removing specific milestone as this depends on repo manager work to be done in bug 259598.
Comment 23 Pascal Rapicault CLA 2009-02-21 00:19:12 EST
*** Bug 265592 has been marked as a duplicate of this bug. ***
Comment 24 Susan McCourt CLA 2009-02-26 16:31:26 EST
Created attachment 126903 [details]
work in progress

attaching patch for John ... this is not polished, but demonstrates the use of the repo manager api.
Comment 25 Susan McCourt CLA 2009-02-26 18:12:45 EST
fixed in HEAD >20090226.
- there is a name field in the add repo dialog
- you can edit the name in the pref dialog
- nickname is not required
- displayed name is nickname if not null, or else name if not null, or else location string
- drag/drop operations and other "auto-add" gestures does not create a nickname
- nicknames are now set when reading UM site bookmarks
- displayed name (wherever it came from) is still exported as the site name

One caveat is that until bug 265973 is fixed, the nickname is not being preserved across shutdown, but I tested with a partial patch John gave me and it will work when that is fixed.

Added test cases that verify nickname import/export.