Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 193703 - Shells out of a display bounds makes page scrollable
Summary: Shells out of a display bounds makes page scrollable
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 1.3 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-21 08:43 EDT by Benjamin Muskalla CLA
Modified: 2009-10-12 08:24 EDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (2.29 KB, patch)
2009-09-10 03:50 EDT, Asen Draganov CLA
ruediger.herrmann: iplog+
Details | Diff
New patch (1.67 KB, patch)
2009-09-17 07:15 EDT, Asen Draganov CLA
no flags Details | Diff
experimental: setting body.position to "absolute" (905 bytes, patch)
2009-10-06 10:45 EDT, Tim Buschtoens CLA
no flags Details | Diff
Proposed solution (1.03 KB, patch)
2009-10-07 07:53 EDT, Tim Buschtoens CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2007-06-21 08:43:14 EDT
Easy to reproduce with the demo application.

Just drag the workbench shell down until it's partly hidden. You can now scroll up/down with the mousewheel. Note that no scrollbars are visible and the SWT Display doesn't get resized (seen when you maximize/restore the shell).
Comment 1 Rüdiger Herrmann CLA 2008-09-26 03:05:19 EDT
Benny, can we close this bug? 
To me it seems that this was fixed with one of the qx maintenance releases.
I can't reproduce it anymore or am I missing something?
Comment 2 Benjamin Muskalla CLA 2008-09-26 03:37:44 EDT
Cannot reproduce it with mouse wheel / trackpoint but it's still possible to scroll the page with Down and Up keys.
Tested with FF 3.0.3.
In webkit-based browsers the page has at least a scrollbar.
Comment 3 Asen Draganov CLA 2009-09-10 03:50:35 EDT
Created attachment 146838 [details]
Proposed patch
Comment 4 Rüdiger Herrmann CLA 2009-09-10 06:59:24 EDT
Fixed in CVS HEAD
Comment 5 Ivan Furnadjiev CLA 2009-09-17 07:06:29 EDT
The fix prevents Tree and List from scrolling with mouse wheel.
Comment 6 Asen Draganov CLA 2009-09-17 07:15:57 EDT
Created attachment 147428 [details]
New patch

The "mousewheel" event handling is removed. Currently there is no problem with mouse wheel scrolling in Firefox, IE and Webkit browsers.
Comment 7 Rüdiger Herrmann CLA 2009-09-17 08:03:37 EDT
Applied second patch to CVS HEAD
Comment 8 Rüdiger Herrmann CLA 2009-09-28 12:36:15 EDT
This is causes bug 290248. Reverted changes.
Comment 9 Tim Buschtoens CLA 2009-10-06 10:45:06 EDT
Created attachment 148893 [details]
experimental: setting body.position to "absolute"

Setting body.position to "absolute" blocks any scrolling of the document. I could not make out any side-effect of this solution. I have also no idea why Qooxdoo sets position to "" in ClientDocument.js.
Comment 10 Tim Buschtoens CLA 2009-10-07 06:04:36 EDT
Known side-effects of body.position = "absolute" in FF.
- Text in textfields can not be selected.
- Clicking in a textfield won't make the cursor visible.
- Keyboard-control in multi-line textfields is buggy.

Those effects are emmediately gone if body.position is deleted via firebug.
Only Firefox (tested 2.0 and 3.0) is affected. Works fine in Opera, Safari, Chrome and IE.
Comment 11 Tim Buschtoens CLA 2009-10-07 07:53:51 EDT
Created attachment 148980 [details]
Proposed solution

This should disable scrolling in Firefox without any side-effects.

Info:
- The textfield-bugs appear only if body-style has "-moz-user-select:none" and any value for "position".
- The "-moz-user-select"-attribute is set by the "selectable"-property of ClientDocument. The property can savely be set to true in FF, as all the widgets that could be selectable should have this property set to false themselves. For the way "-moz-user-select" works, that suffices.
- IE however needs "selectable" to be false, so the property is only changed in FF-browsers.
- The reasion behind this behavior is unkown, except that FF has a long and troubled history with similar problems: 
https://bugzilla.mozilla.org/show_bug.cgi?id=167801
Comment 12 Rüdiger Herrmann CLA 2009-10-12 08:24:07 EDT
Applied patch to CVS HEAD