Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 193630 - Cleanup the NLS unused messages from org.eclipse.tptp.trace.report.birt.ui.internal.messages
Summary: Cleanup the NLS unused messages from org.eclipse.tptp.trace.report.birt.ui.in...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sheldon Lee-Loy CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-20 18:46 EDT by Alex Nan CLA
Modified: 2016-05-05 11:09 EDT (History)
1 user (show)

See Also:
ewchan: review+

Attachments
Patch for review (1.90 KB, patch)
2007-08-02 10:27 EDT, Sheldon Lee-Loy CLA 		sleeloy: review+
Details | Diff
updated patch (3.03 KB, patch)
2007-08-07 12:46 EDT, Eugene Chan CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nan CLA 2007-06-20 18:46:40 EDT 
When you launch TPTP SDK or just TPTP runtime a lot of unused NLS msgs in org.eclipse.tptp.trace.report.birt.ui.internal.messages warnings are logged into the Eclipse .log.
Please clean the unused keys from the NLS class.
Comment 1 Alex Nan CLA 2007-06-20 18:48:04 EDT 
I mean clean up the unused keys from the org.eclipse.tptp.trace.report.birt.ui.internal.messages resource bundle class.
Comment 2 Guru Nagarajan CLA 2007-06-25 19:08:30 EDT 
This has been retargetted to 4.4.1.
Please triage this to the right version
Comment 3 Sheldon Lee-Loy CLA 2007-08-02 10:26:09 EDT 
The reason this happens is that the BIRT report template file uses these properties file but these entries doesn't need to be in the Message.java.  However to remove the warning messages I need to add the properties entry to the Message.java
Comment 4 Sheldon Lee-Loy CLA 2007-08-02 10:27:30 EDT 
Created attachment 75229 [details]
Patch for review

The patch that contains the fix.  Alex can you review this patch before I check it in.
Comment 5 Sheldon Lee-Loy CLA 2007-08-07 10:47:39 EDT 
Eugene can you review this patch since Alex on vacation.
Comment 6 Eugene Chan CLA 2007-08-07 12:46:20 EDT 
Created attachment 75556 [details]
updated patch

Sheldon, I updated the copyright year and the plugin version for your patch.
Comment 7 Eugene Chan CLA 2007-08-07 12:46:48 EDT 
(In reply to comment #4)
> Created an attachment (id=75229) [details]
> Patch for review
> 
> The patch that contains the fix.  Alex can you review this patch before I check
> it in.
> 

Patch looks safe to me.
Comment 8 Sheldon Lee-Loy CLA 2007-08-07 12:50:03 EDT 
Applied patch.
Comment 9 Paul Slauenwhite CLA 2009-06-30 10:32:40 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.