Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 193571 - [Dialogs] FilteredItemsSelectionDialog does not immediately remove last history match
Summary: [Dialogs] FilteredItemsSelectionDialog does not immediately remove last histo...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3.1   Edit
Assignee: Krzysztof Michalski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-20 12:48 EDT by Markus Keller CLA
Modified: 2007-09-06 08:43 EDT (History)
6 users (show)

See Also:

Attachments
Fix (1.18 KB, patch)
2007-08-31 09:53 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-06-20 12:48:52 EDT 
I20070615-1200

FilteredItemsSelectionDialog does not immediately remove the last remaining history match:

- new workspace
- new Java project

- Navigate > Open Type "ArrayList"
- Navigate > Open Type "AbstractList"
- close both editors

- slow down search, e.g. by adding Thread.sleep(..) at the beginning of fillContentProvider(..)

- Navigate > Open Type
- slowly type "Arx"
=> after "Ar", "AbstractList" gets correctly removed
=> after "Arx", "ArrayList" should also be removed, but it wrongly stays
Comment 1 Markus Keller CLA 2007-08-31 09:53:01 EDT 
Created attachment 77467 [details]
Fix

I really think this should be fixed for 3.3.1.

This bug shows up all the time in normal development workspaces. As soon as the pattern does not match anything in the history any more, the "Matching items" list becomes stale and keeps showing non-matching entries until the matches from the search engine become available.

The fix is an easy one-liner. The modified if-clause has been added to fix bug 189106, but the check for empty history is wrong and not necessary to fix that bug.
Comment 2 Szymon Brandys CLA 2007-08-31 12:15:48 EDT 
Released to 3.3_maintanance.
Comment 3 Szymon Brandys CLA 2007-08-31 12:39:42 EDT 
Released to HEAD. Thanks Markus.
Comment 4 Dani Megert CLA 2007-09-06 08:43:24 EDT 
Verified in M20070905-1045.