Comment 1 Neil Hauge 2007-06-22 12:41:25 EDT

The user must restart the Workbench to get past the validation issue noted below if the below steps are followed.  

It does appear though that the project must to be closed and opened in the same Workbench session for items 3, 4, and 5 to occur, which would limit the exposure to this problem.

We should investigate this issue for 1.0.1.

The tip of the stack trace for the stack overflow:

java.lang.StackOverflowError
	at java.io.FileOutputStream.writeBytes(Native Method)
	at java.io.FileOutputStream.write(FileOutputStream.java:260)
	at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:65)
	at java.io.BufferedOutputStream.write(BufferedOutputStream.java:109)
	at java.io.PrintStream.write(PrintStream.java:412)
	at sun.nio.cs.StreamEncoder$CharsetSE.writeBytes(StreamEncoder.java:336)
	at sun.nio.cs.StreamEncoder$CharsetSE.implFlushBuffer(StreamEncoder.java:404)
	at sun.nio.cs.StreamEncoder.flushBuffer(StreamEncoder.java:115)
	at java.io.OutputStreamWriter.flushBuffer(OutputStreamWriter.java:169)
	at java.io.PrintStream.write(PrintStream.java:459)
	at java.io.PrintStream.print(PrintStream.java:602)
	at org.eclipse.core.runtime.adaptor.EclipseLog.write(EclipseLog.java:551)
	at org.eclipse.core.runtime.adaptor.EclipseLog.writeln(EclipseLog.java:570)
	at org.eclipse.core.runtime.adaptor.EclipseLog.writeEntry(EclipseLog.java:494)
	at org.eclipse.core.runtime.adaptor.EclipseLog.writeLog(EclipseLog.java:472)
	at org.eclipse.core.runtime.adaptor.EclipseLog.log(EclipseLog.java:300)
	at org.eclipse.core.internal.runtime.PlatformLogWriter.logging(PlatformLogWriter.java:36)
	at org.eclipse.core.internal.runtime.RuntimeLog.log(RuntimeLog.java:95)
	at org.eclipse.core.internal.runtime.InternalPlatform.log(InternalPlatform.java:671)
	at org.eclipse.core.internal.runtime.Log.log(Log.java:56)
	at org.eclipse.wst.xml.core.internal.Logger._log(Logger.java:78)
	at org.eclipse.wst.xml.core.internal.Logger.logException(Logger.java:143)
	at org.eclipse.wst.xml.core.internal.document.DOMModelImpl.noChange(DOMModelImpl.java:621)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument._fireEvent(BasicStructuredDocument.java:515)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.fireStructuredDocumentEvent(BasicStructuredDocument.java:1173)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.internalReplaceText(BasicStructuredDocument.java:1950)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.replaceText(BasicStructuredDocument.java:2394)
	at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument.replaceText(JobSafeStructuredDocument.java:84)
	at org.eclipse.wst.xml.core.internal.document.XMLModelUpdater.replaceSource(XMLModelUpdater.java:1608)
	at org.eclipse.wst.xml.core.internal.document.XMLModelUpdater.replaceChild(XMLModelUpdater.java:1566)
	at org.eclipse.wst.xml.core.internal.document.DOMModelImpl.childReplaced(DOMModelImpl.java:188)
	at org.eclipse.wst.xml.core.internal.document.NodeContainer.notifyChildReplaced(NodeContainer.java:357)
	at org.eclipse.wst.xml.core.internal.document.NodeContainer.removeChild(NodeContainer.java:401)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.removeDOMChild(EMF2DOMAdapterImpl.java:685)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.removeDOMChild(EMF2DOMAdapterImpl.java:671)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.primUpdateDOMMultiFeature(EMF2DOMAdapterImpl.java:374)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.updateDOMRootFeature(EMF2DOMAdapterImpl.java:940)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.primUpdateDOM(EMF2DOMAdapterImpl.java:916)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.notifyChangedForRoot(EMF2DOMAdapterImpl.java:1051)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.notifyChanged(EMF2DOMAdapterImpl.java:1012)
	at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:247)
	at org.eclipse.emf.common.notify.impl.NotificationImpl.dispatch(NotificationImpl.java:1030)
	at org.eclipse.emf.common.notify.impl.NotifyingListImpl.addUnique(NotifyingListImpl.java:367)
	at org.eclipse.emf.common.util.BasicEList.add(BasicEList.java:672)
	at org.eclipse.wst.common.internal.emf.resource.RootTranslator.setMOFValue(RootTranslator.java:34)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.primUpdateMOFMultiFeature(EMF2DOMAdapterImpl.java:436)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.updateMOFRootFeature(EMF2DOMAdapterImpl.java:952)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.primUpdateMOF(EMF2DOMAdapterImpl.java:927)
	at org.eclipse.wst.common.internal.emf.resource.EMF2DOMAdapterImpl.updateMOF(EMF2DOMAdapterImpl.java:911)
	at org.eclipse.wst.xml.core.internal.emf2xml.EMF2DOMSSEAdapter.notifyChanged(EMF2DOMSSEAdapter.java:224)
	at org.eclipse.wst.sse.core.internal.provisional.AbstractNotifier.notify(AbstractNotifier.java:201)
	at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.notifyStructureChanged(XMLModelNotifierImpl.java:392)
	at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.endChanging(XMLModelNotifierImpl.java:180)
	at org.eclipse.wst.xml.core.internal.document.DOMModelImpl.changedModel(DOMModelImpl.java:163)
	at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel$DocumentToModelNotifier.nodesReplaced(AbstractStructuredModel.java:152)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument._fireEvent(BasicStructuredDocument.java:602)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.fireStructuredDocumentEvent(BasicStructuredDocument.java:1201)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.internalReplaceText(BasicStructuredDocument.java:1970)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.replaceText(BasicStructuredDocument.java:2394)
	at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument.replaceText(JobSafeStructuredDocument.java:84)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.set(BasicStructuredDocument.java:2908)
	at org.eclipse.core.internal.filebuffers.ResourceTextFileBuffer.handleFileContentChanged(ResourceTextFileBuffer.java:479)
	at org.eclipse.core.internal.filebuffers.ResourceFileBuffer.revert(ResourceFileBuffer.java:354)
	at org.eclipse.wst.sse.core.internal.FileBufferModelManager.revert(FileBufferModelManager.java:701)
	at org.eclipse.wst.sse.core.internal.model.ModelManagerImpl.revertModel(ModelManagerImpl.java:1408)
	at org.eclipse.wst.sse.core.internal.model.ModelManagerImpl.releaseFromEdit(ModelManagerImpl.java:1397)
	at org.eclipse.wst.sse.core.internal.model.ModelManagerImpl.releaseFromEdit(ModelManagerImpl.java:1345)
	at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel.releaseFromEdit(AbstractStructuredModel.java:1044)
	at org.eclipse.wst.xml.core.internal.document.DOMModelImpl.releaseFromEdit(DOMModelImpl.java:804)
	at org.eclipse.wst.xml.core.internal.emf2xml.EMF2DOMSSERenderer.modelChanged(EMF2DOMSSERenderer.java:382)
	at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel.fireModelChanged(AbstractStructuredModel.java:553)
	at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel.internalModelChanged(AbstractStructuredModel.java:887)
	at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel.changedModel(AbstractStructuredModel.java:382)
	at org.eclipse.wst.xml.core.internal.document.DOMModelImpl.changedModel(DOMModelImpl.java:167)
	at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel$DocumentToModelNotifier.nodesReplaced(AbstractStructuredModel.java:152)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument._fireEvent(BasicStructuredDocument.java:602)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.fireStructuredDocumentEvent(BasicStructuredDocument.java:1201)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.internalReplaceText(BasicStructuredDocument.java:1970)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.replaceText(BasicStructuredDocument.java:2394)
	at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument.replaceText(JobSafeStructuredDocument.java:84)
	at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.set(BasicStructuredDocument.java:2908)
	at org.eclipse.core.internal.filebuffers.ResourceTextFileBuffer.handleFileContentChanged(ResourceTextFileBuffer.java:479)

Comment 2 Neil Hauge 2007-06-26 10:46:26 EDT

More info:
The persistence.xml and orm.xml (this also affect orm.xml) that appear truncated after re-opening the project are actually still intact on the file system.  If the user does not save these truncated versions and restarts the workbench, the files will return with their previous content.

Comment 3 Neil Hauge 2007-06-26 10:50:59 EDT

*** Bug 194318 has been marked as a duplicate of this bug. ***

Comment 4 Svetozar Peev 2007-07-20 06:01:30 EDT

A little different scenario to reproduce the defect with the latest WTP , DALI and Eclipse updates (20.07.07):
 1.Create EJB 3.0 project with JPA Facet
 2.Create single entity class in the project (e.g. with one @Id field only)
 3.Switch to another workspace and import the project from previos one (with copy)
 4.The "No persistence.xml" problems appear, but if you open the persistence.xml it's ok
 5.Delete the project (with content, from current workspace) and import it with copy again
 6.The problem does not appear but the situation like in the attached sceenshot 
can be seen. - If you open the persistence.xml from "ejbModule" folder, 
it will be empty, if you open it from "Build" folder it will be "Ok"    

Comment 5 Svetozar Peev 2007-07-20 06:03:11 EDT

Created attachment 74247 [details]
Screenshot for Comment  #4

Comment 6 Kaloyan Raev 2007-08-22 02:46:38 EDT

I raise this as hotbug. 
This issue affects important use cases for SAP. 
We hope to have it fixed for 1.0.1. 

Comment 7 kiril mitov 2007-08-29 03:56:11 EDT

Created attachment 77216 [details]
A first look fix.

Hope to help identify the problem

Comment 8 kiril mitov 2007-08-29 03:57:59 EDT

I have investigate the problem for a while and a have prepared a patch (just and idea), but the change is made in org.eclipse.wst.common.emf and because of that I do not like it very much. I do not know what else is effected.

The general description of the problem as I understand it.

The JpaModelManager has two listeners - facetedProjectListener, resourceChangeListener. This two listeners have the task to update the model as the projects and files are changed. When a resource is change  a jpaProject is created and jpaProject.fill() is called. Filling the project means calling PersistenceXmlJpaFileContentProvider::buildRootContent(jpaFile). 

The following line located in buildRootContent() does the actual loading of the file 
PersistenceResource resource = (PersistenceResource) getResourceSet(resourceFile).getResource(fileURI, true);
This line is successfully executed the first time the method is called for a fileURI. Loading the model includes reading and creating dom element and the corresponding EMF2DOM adapters.For every node and for its children an adapter is created. 

To create the adapter EMF2DOMAdapterImpl::createAdapter(Node node, Translator childMap) is called. The method delegates to EMF2DOMSSEAdapter::primGetExistingAdapter() which tries to find a cached adapter for the node. If the attached patch is applied then no existingAdapter is used and  the adapters are created every time. The user will be able to close and open a project without exceptions thrown and without loosing the persistence.xml and orm.xml

I will try to further investigate why are the existingAdapters causing the problem

Comment 9 Neil Hauge 2007-08-29 10:13:55 EDT

Paul has been investigating this, assigning to him.

Comment 10 Paul Fullbright 2007-08-29 16:36:48 EDT

Copying some comments I made to Dimiter on the JPT mailing list:

"Yes, this is one of the more annoying bugs we have.  (We have a utility to generate unique project names for our JUnit tests, so we've worked around one of your issues that way.)  Truth is, I know *when* it happens, but I really have no idea *why* it happens.  It only happens when creating a resource with a given path (say "MyProject/src/META-INF/persistence.xml"), deleting or closing the project, and then attempting to recreate the resource with the same path.  *Something* isn't being cleaned up or disposed, but again, I don't know what exactly.  I've been experimenting with ArtifactEdits in an alt stream, and I've seen a disappearance of most or all of these issues, but again, I'm not sure why, and I'm not sure I understand the code  well enough (lack of documentation is a big problem here) to feel good about introducing it into our maintenance stream.  But that is what I'm going to look into doing.  This bug is big enough that even some problems caused by (mis)use of ArtifactEdits are probable worth it.

Incidentally, this issue won't crop up when importing a brand new project into a workspace.  It only occurs when importing a project into a workspace in which it has been deleted in the same session (i.e. delete, then reimport.)"


I'm currently waiting on some feedback from WTP developers.  Hopefully that will help me resolve this issue ASAP.

Comment 11 Paul Fullbright 2007-09-05 12:32:48 EDT

Created attachment 77741 [details]
proposed patch

This patch looks pretty good so far to me.  I've used the artifact edit framework, and there don't seem to be any major issues.

Please test this out and let me know if there are any issues.  We'd like to get this into our RC build.

Comment 12 Paul Fullbright 2007-09-05 17:33:31 EDT

Created attachment 77756 [details]
proposed patch

Slightly tweaked patch to fix a few minor problems.

Overall, we did discover that *functionally* sometimes this fix is *not* an improvement over non-patched code.  Sometimes, the orm and persistence models are not reloaded on project reopen/reimport.  But the patch does seem to remove completely all exceptions, so we're going to go with this patch for the time being as an improvement and hope to fix the remaining issues post-RC.

(committed patch for RC build)

Comment 13 Paul Fullbright 2007-09-06 13:58:14 EDT

Created attachment 77839 [details]
patch addendum

This looks to fix the problem uncovered by the previous bug fix.  A race condition was addressed.

Comment 14 Paul Fullbright 2007-09-06 14:01:30 EDT

committed to post-RC code.

(If downloading the RC, you should simply be able to use the patch addendum)

Comment 15 Neil Hauge 2007-09-25 09:05:23 EDT

I have verified this fix myself, but since this is a hot bug, I thought the requester may want to verify as well.  Please update the bug if you have any issues.

Comment 16 Kaloyan Raev 2007-09-25 09:22:32 EDT

I think a colleague already verified it, but I will do it again with RC3. 

Comment 17 Kaloyan Raev 2007-09-25 09:51:38 EDT

I have verified the "steps to reproduce" from both the bug description and comment #4. They are OK with WTP 2.0.1 RC3.