Description Nick Boldt 2007-06-12 11:45:57 EDT

This was tricky to diagnose, so I'm wondering if it merits a better error message in the build log when this happens. Here's the scenario:

a) trying to build EMF Validation component using latest releng.basebuilder (tag RC3_33)

b) build fails when running /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.validation.releng/builder/tests/customTargets.xml as there's no value defined for ${org.eclipse.test}, so directory doesn't exist and tests can't be built or run

c) up to and including tag M4_33, ${org.eclipse.test} was set in test.properties

    <generateTestProperties 
            buildDirectory="${buildDirectory}" 
            featureId="org.eclipse.emf.${subprojectName}.tests" 
            outputFile="${workingDirectory}/testing/test.properties" 
    /> 

d) now, it only sets a value if the test feature's feature.xml has plugin versions set to 0.0.0:

  <plugin
         id="org.eclipse.test"
         download-size="0"
         install-size="0"
         version="0.0.0"/>

   <plugin
         id="org.eclipse.ant.optional.junit"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"/>

instead of:

  <plugin
         id="org.eclipse.test"
         download-size="0"
         install-size="0"
         version="3.1.0"/>

   <plugin
         id="org.eclipse.ant.optional.junit"
         download-size="0"
         install-size="0"
         version="2.1.0"
         fragment="true"/>

While I've clearly found a solution to this problem, and can close bug 190834, I just think that there should be a better way to resolve this error message than guessing and comparing with other builds to discover the secret black magic incantation to once again make PDE fall in line. ;-)

  /home/www-data/build/modeling/emf/validation/downloads/drops/1.1.0/
  N200706121134/org.eclipse.emf.validation.releng/builder/tests/
  customTargets.xml:231: /home/www-data/build/modeling/emf/validation/
  downloads/drops/1.1.0/N200706121134/eclipse/test.assembly/eclipse/
  plugins/${org.eclipse.test} not found.

Could a check be done when <generateTestProperties/> runs to ensure a value is set for org.eclipse.test? Or could an option be added such that values in the feature.xml are ignored? Or, perhaps best, if there's a plugin version value found in the feature.xml, put *THAT* value into the test.properties file, as before in M4_33.

If you disagree completely, you can close this as WORKSFORME or INVALID. I'd just like to save others this debugging hassle, if at all possible. ;-)