Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 191437 - Labels are missing
Summary: Labels are missing
Status: RESOLVED WONTFIX
Alias: None
Product: GMF-Tooling
Classification: Modeling
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Artem Tikhomirov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-07 05:15 EDT by Jens Bachmann CLA
Modified: 2010-07-19 22:19 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Bachmann CLA 2007-06-07 05:15:02 EDT
Build ID: I20070525-1350

Steps To Reproduce:
Everything works fine with GMF2.0RC1, but now labels are missing for my compartments and the connections with GMF2.0RC2.
1.Generate new code of my models with RC2
2.Create new compartment in my diagram
3.Labels are missing
4.Same for my connections


More information:
I downloaded the Night build N20070607 and the problem with compartments is away, but the labels for my connections are still not displayed. I checked the differences between code of RC1 and RC2 of the editparts of these labels of connections and found out, that the method "createFigure()" was changed. If I change this with old generated one it works nice. 
The new method looks like this:
protected IFigure createFigure() {
  // Parent should assign one using setLabel() method
  return null;
}
I think there is the problem, because parent class doesn't call a setLabel() method.
Comment 1 Artem Tikhomirov CLA 2007-06-07 09:35:07 EDT
Labels inside compartments has been "fixed" yesterday with bug #191303 (it's not really a fix, kinda workaround, as you need to specify layout explicitly instead of relying on some default code in the editpart).

As for link's label, the code you show means that DiagramLabel from your .gmfgraph which you use for link label points to some nested figure inside other figure, and, I bet, that other figure is not the one you use for the link. I'd suggest to have another diagram label, which would point (with figure reference) to appropriate FigureDescriptor and won't be using child accessors.
Comment 2 Richard Gronback CLA 2008-08-13 13:12:08 EDT
[target cleanup] 2.0 RC was the original target milestone for this bug
Comment 3 Eclipse Webmaster CLA 2010-07-19 22:19:23 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug