Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 190802 - Applying filters on an attached agent has no effect
Summary: Applying filters on an attached agent has no effect
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Asaf Yaffe CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords:
: 193429 193803 (view as bug list)
Depends on: 179354
Blocks:
  Show dependency tree
 
Reported: 2007-06-04 09:21 EDT by Asaf Yaffe CLA
Modified: 2016-05-05 10:41 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Asaf Yaffe CLA 2007-06-04 09:21:40 EDT
When dynamically attaching to a JVMTI Profiler, the filters specified in UI are ignored and has no effect.

Filters can be dynamically applied only by using dynamic byte-code instrumentation (RedefineClasses), which is currently disabled due to Bug 179354.
Comment 1 Asaf Yaffe CLA 2007-06-04 09:22:52 EDT
Retargetting to future. Will be resolved with Bug 179354.
Comment 2 Asaf Yaffe CLA 2007-06-04 09:26:54 EDT
Reassigning to myself
Comment 3 Asaf Yaffe CLA 2007-06-21 10:54:44 EDT
Resolving this bug will take ~2 weeks, as it depends on Bug 179354 (it is caused by the current workaround implemented for 179354). Therefore, it probably cannot be contained in 4.4.0.1
Comment 4 Guru Nagarajan CLA 2007-06-21 14:38:04 EDT
*** Bug 193803 has been marked as a duplicate of this bug. ***
Comment 5 Asaf Yaffe CLA 2007-06-24 03:39:13 EDT
*** Bug 193429 has been marked as a duplicate of this bug. ***
Comment 6 Guru Nagarajan CLA 2007-06-29 13:00:28 EDT
Lowering priority P2 
Comment 7 Harm Sluiman CLA 2007-07-06 07:37:23 EDT
I am still at a loss to understand how we can live without this fix. the attach scenario is our most common TPTP use case, when profiling web applications. To a user this is a significant functional regression from the PI support.

The amount of time it takes to do a large app is a secondary issue and we should be leveraging the progress indicator (not a user message). But first the base function needs to work.

What progress has been made on this defect and what is an updated out look to fix and then test assuming we have help with the testing?
Comment 8 Guru Nagarajan CLA 2007-07-06 11:36:47 EDT
This fix was estimated at 3 weeks and cannot be contained by next week (Week of July 9th). 
Comment 9 Harm Sluiman CLA 2007-07-06 12:14:02 EDT
(In reply to comment #8)
> This fix was estimated at 3 weeks and cannot be contained by next week (Week of
> July 9th). 

ok, so I see a sizing of 80 hours, and there has been some investigation and now the time is 3 weeks (120 hours) How much elapsed time will it take with testing help etc..? 
If not containable for the week of the 9th, we need to understand when it can be contained by and perhaps negotiate with consumers based on that.

I am pushing on this because of what appears to be a major limitation for our server profiling scenarios among others. If my impression is wrong please help me better understand the scope of impact.
Comment 10 Guru Nagarajan CLA 2007-07-06 12:17:11 EDT
This defect is blocked by 179354 (40 hours) + 80 for this. 
The earliest we can look for is the week of July 16th.
Comment 11 Harm Sluiman CLA 2007-07-06 12:33:02 EDT
(In reply to comment #10)
> This defect is blocked by 179354 (40 hours) + 80 for this. 
> The earliest we can look for is the week of July 16th.

Thanks, although the threads in these bugzilla are a bit hard to follow, I understand that 179354 is only a problem where alternate class loaders are used. Is this defect also only scoped to that environment or is there a broader issue involved in this defect? What is the unqiue part of this defect? It seems that 179354 is implicitely having to dynamically apply a filter.
Comment 12 Asaf Yaffe CLA 2007-07-08 03:34:35 EDT
(In reply to comment #11)
> What is the unqiue part of this defect? It seems
> that 179354 is implicitely having to dynamically apply a filter.

That's right. This bug is a manifestation of bug 179354 from end-user perspective. However, while dynamic class redefinition is a key part of dynamic filtering, there is additional logic involved with communicating the filters from the workbench to the profiler runtime. I believe this logic was not thoroughly tested and would therefore recommend to keep this bug open in order to track the completion of this feature.
Comment 13 Paul Slauenwhite CLA 2007-07-16 09:04:55 EDT
Triaging 4.4.0.2 candidate defects for Joanna.  

This is a 4.4.0.2 candidate defect since deferred from 4.4.0.1.

Asaf, please target to 4.4.0.2 when the field is available.
Comment 14 Paul Slauenwhite CLA 2007-07-16 09:05:35 EDT
Increasing priority.
Comment 15 Guru Nagarajan CLA 2007-08-03 02:07:23 EDT
Cannot be contained in 4402
Comment 16 Asaf Yaffe CLA 2007-08-23 06:41:56 EDT
Resolved.
The current fix does not support IBM 1.5 JVM as it does not properly support
the JVMTI RedefineClasses API.
Comment 17 Paul Slauenwhite CLA 2009-06-30 13:27:02 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 18 Paul Slauenwhite CLA 2009-06-30 13:47:37 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.