Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 190548 - [Editor] XML Schema editor's extensions view intermittently fails to show the correct editing controls
Summary: [Editor] XML Schema editor's extensions view intermittently fails to show the...
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P1 major (vote)
Target Milestone: 2.0 RC3   Edit
Assignee: Craig Salter CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-01 15:32 EDT by Craig Salter CLA
Modified: 2007-07-05 15:06 EDT (History)
6 users (show)

See Also:
david_williams: pmc_approved+
jlanuti: pmc_approved? (jgarms)
raghunathan.srinivasan: pmc_approved+
jlanuti: pmc_approved? (naci.dai)
jlanuti: pmc_approved? (deboer)
jlanuti: pmc_approved? (neil.hauge)
csalter: review+

Attachments
undoes most of the change from bug 139092 (19.61 KB, patch)
2007-06-05 23:59 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
rollback patch for tests (978 bytes, patch)
2007-06-06 00:11 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Salter CLA 2007-06-01 15:32:29 EDT 
The XML Schema editor's extension view depends on the XML document's content model to render the correct editing controls for fields (combo boxes will be shown when there are fixed values for fields).  If I open an XML Schema and view the extension properties things will work as expected at first.  However if I move to another editor to do other work and eventually come back to the extensions view I notice that the editor's control are created incorrectly as though the underlying content model has been lost.
Comment 1 Craig Salter CLA 2007-06-01 15:45:46 EDT 
This is a functional regression from WTP 1.5.x that seems to have been introduced by changes implemented for bug 139092.
Comment 2 Nitin Dahyabhai CLA 2007-06-05 23:59:50 EDT 
Created attachment 70271 [details]
undoes most of the change from bug 139092

I'm attaching a patch to roll back most of the changes that were made to fix bug 139092; we'll have to revisit them early in V3.  It's pretty much a full undo except it retains Valentin's changes for bug 136399 where they overlapped.
Comment 3 Nitin Dahyabhai CLA 2007-06-06 00:02:42 EDT 
Craig, I'm flagging you to review (you'll want to compare org.eclipse.wst.xml.core.internal.contentmodel.util.CMDocumentCache.java against its 1.2 revision for simplicity).  Can you target this change for RC3?
Comment 4 Nitin Dahyabhai CLA 2007-06-06 00:11:27 EDT 
Created attachment 70272 [details]
rollback patch for tests

Whoops, forgot to include the test plugins when generating the patch.
Comment 5 Craig Salter CLA 2007-06-12 15:46:27 EDT 
The rolled back changes look good.  Marking for PMC approval.
Comment 6 Raghunathan Srinivasan CLA 2007-06-12 18:32:12 EDT 
Bad regression. Try to get this in for RC3.
Comment 7 Keith Chong CLA 2007-06-13 14:57:45 EDT 
Patches have been committed and released for WTP 2.0.
Comment 8 Craig Salter CLA 2007-07-05 15:06:54 EDT 
Closing.