Community
Participate
Working Groups
In Eclipse SDK, that is. org.eclipse.osgi seems to have source But, these two don't. org.eclipse.osgi.services org.eclipse.osgi.util
they likely come from Orbit and are suffering the same fate as all other bundles from Orbit. Should be corrected soon.
These bundles aren't in Orbit.
Those two plug-ins did not have source in 3.2.1 either.
Yeah but that was likely a bug then too... the Platform source feature does include dirs for the services and utils bundles but there is no source there. That does seem like an error that should be corrected for 3.3.
The issue in this case is that the src.zip is deleted in the clean target of the generated build.xml. For example, here's this target from a recent build <target name="clean" depends="init" description="Clean the plug-in: org.eclipse.osgi.services of all the zips, jars and logs created."> <delete dir="${build.result.folder}/@dot"/> <delete file="${build.result.folder}/src.zip"/> <delete file="${plugin.destination}/org.eclipse.osgi.services_3.1.100.v20060918.jar"/> <delete file="${plugin.destination}/org.eclipse.osgi.services_3.1.100.v20060918.zip"/> <delete dir="${temp.folder}"/> </target> Thus when the gather.sources target runs, the src.zip no longer exists on the filesystem and so it is not included in the build. You should be able to use a customCallback to avoid this problem.
FYI, After I opened this bug, Wassim, in bug 189972 #c5 implies these were intentionally omitted before because they "wouldn't compile" if pulled in as source. (And, not that I understand why that would be ... I'm just the messenger connecting bugzillas).
Created attachment 69746 [details] patch for services and util Here is a patch for the osgi.services and osgi.util bundles. Along with the patch, you must rename the source zips to be services_src.zip and util_src.zip, respectively.
The patch should do the rename in the pre.gather.source
+1 for the idea of finally fixing this for 3.3
Created attachment 69759 [details] patch for services and util Good catch, Pascal. Thanks.
+1 to fix, but I'm deferring my code review to Andrew who will be more helpful in custom pde build scripts.
Note that the "rename the source zips" step from comment #7 is still necessary with the new patch.
Created attachment 69794 [details] updated patch for services and util The src.includes property should include src.zip not services_src or util_src The build.properties also needs a customBuildCallbacks=customBuildCallbacks.xml This still requires the src.zip to be renamed to services_src.zip in cvs.
Created attachment 69796 [details] alternative patch This alternative instead uses the pre.clean and post.clean to temporarily rename and then restore the src.zip so that it doesn't get deleted on the clean. This does not require the src.zip to be renamed in cvs.
+1 for Andrew's alternative patch. Was able to construct a test build and it works well.
+1 for Andrew's patch.
+1 for the alternative patch over the other one
Released to HEAD.
