Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 189000 - Update sites missing in I20070524-0010
Summary: Update sites missing in I20070524-0010
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P1 blocker (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 187296
  Show dependency tree
 
Reported: 2007-05-24 14:39 EDT by Michael Valenta CLA
Modified: 2007-05-28 11:12 EDT (History)
6 users (show)

See Also:


Attachments
comparison of map files between I20070523-0010 and I20070524-0010 (33.16 KB, patch)
2007-05-24 21:34 EDT, Kim Moir CLA
no flags Details | Diff
Arbitrary update sites broken too (78.00 KB, image/png)
2007-05-25 09:38 EDT, Kim Horne CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2007-05-24 14:39:08 EDT
In previous builds, there has always been a Europa Update site available in the Update manager. In build I20070524-0010, this seems to have disappeared.
Comment 1 Kim Moir CLA 2007-05-24 15:44:49 EDT
Confirmed.  I don't know why because the update sites still exist in the feature - this hasn't changed in months.  Dejan?
Comment 2 Dejan Glozic CLA 2007-05-24 19:44:29 EDT
This is very strange. When I set up the build for Update self-hosting, I can see the links in the second Eclipse instance, but not in the host eclipse.

Notice another thing: when I open Manage Configuration link, no features show up except the root feature (no install locations). When I launch Eclipse from Eclipse, I can see these correctly.

We need to find out when this stopped working and if there were changes in the runtime around that time -this looks to me like location URL resolution. URLs are somewhat different when launching Eclipse from Eclipse and install locations are found.
Comment 3 Dejan Glozic CLA 2007-05-24 19:56:31 EDT
I tried I20070522-0010 and it works. Apparently this is very fresh.
Comment 4 Dejan Glozic CLA 2007-05-24 20:01:58 EDT
Also works in I20070523-0010.
Comment 5 Dejan Glozic CLA 2007-05-24 20:05:48 EDT
Got it - the problem first started in I20070524-0010. Kim, Update didn't make contributions to that build. We need to chase who did.
Comment 6 Kim Moir CLA 2007-05-24 21:32:16 EDT
There were many contributors to this build - see http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg09419.html

I've compared the maps between these two builds and will attach a patch with the specific changes.
Comment 7 Kim Moir CLA 2007-05-24 21:34:10 EDT
Created attachment 68701 [details]
comparison of map files between I20070523-0010 and I20070524-0010
Comment 8 Dejan Glozic CLA 2007-05-24 21:47:34 EDT
Without further insight, I would definitely start with the OSGi changes. JDT, text, compare, PDE etc. are too high up to affect Update Core.
Comment 9 Kim Horne CLA 2007-05-25 09:38:36 EDT
Created attachment 68767 [details]
Arbitrary update sites broken too

Just to articulate it, this breaks any kind of update site.  I added my own update site for my dynamic tools (pookzilla.net/dynamic) and I could not install the feature as it depended on org.eclipse.ui (which is invisible/unavailable/unclean/unflattering/whatevs)
Comment 10 Thomas Watson CLA 2007-05-25 09:49:14 EDT
Can someone point me to the code that populates the update sites?  

The only changes in OSGi from I20070522-0010 to I20070524-0010 was to the
resolver.  I'm not sure how that would effect update sites.  You mention
install locations.  Maybe the launcher is not calculating this correctly.  I
need to do some more investigation.
Comment 11 DJ Houghton CLA 2007-05-25 09:59:05 EDT
Dejan, where did you get build i0523-0010? I can't find it on the web site.

I tried 0522-0010 and it worked ok.
I tried 0524-0010 and its broken.

Unfortuanatly the releng project wasn't tagged for the 0522 build so its hard to compare the map file changes and post the diffs. A ton of projects changed, including update.core and update.ui.
Comment 12 DJ Houghton CLA 2007-05-25 10:21:09 EDT
I have i0523-0010 on my linux box so it must have been on the web site at one point.

Confirmed that its also a problem on Linux.
Comment 13 Chris Aniszczyk CLA 2007-05-25 10:29:36 EDT
Dejan, what about bug 179210? That's the only thing I can think of without digging into the problem.
Comment 14 DJ Houghton CLA 2007-05-25 10:44:14 EDT
fyi: dropping the i0522 update.core, update.ui and osgi into the i0524 build doesn't help.
Comment 15 Dejan Glozic CLA 2007-05-25 11:10:13 EDT
How about startup code?
Comment 16 DJ Houghton CLA 2007-05-25 11:21:19 EDT
I replaced the launcher and exe and it is still broken.
Comment 17 Dejan Glozic CLA 2007-05-25 11:25:40 EDT
According to Tom, there is a security exception - one of the JARs is corrupted because of the invalid SHA1 signature for file digest.html.
Comment 18 Dejan Glozic CLA 2007-05-25 11:33:25 EDT
Tom figured it out (Tom, you are so smart!).

It is com.jcraft.jsch_0.1.31.jar - it is corrupted. When I took 0.1.28 from 0522 and dropped it into 0524, it worked again.
Comment 19 Kim Horne CLA 2007-05-25 11:39:47 EDT
One corrupt jar can cause this many problems?
Comment 20 Michael Valenta CLA 2007-05-25 11:46:47 EDT
I suspected the transition to JSch 0.1.31 was a bit to easy up until now. For RC2, we should just revert to 0.1.28. We can work out the JAR singing next week.

However, I think it is clear that work needs to happen elsewhere. The JAR works fine in Eclipse so it would seem that Update (or someone else) is eating an exception that should be surfaced in some form (i.e. there is nothing in the log or  anywhere else I could find). Is there already a bug tracking the silent exception or should we just move this one back to Update (or whoever).
Comment 21 Thomas Watson CLA 2007-05-25 12:00:49 EDT
I opened bug 189168 to track this issue in update.  Update code is eating the exception and disabling the whole site for one corrupted bundle.
Comment 22 Kim Moir CLA 2007-05-25 12:29:04 EDT
Reverted to previous version of jsch for next i-build, see bug 187296.
Comment 23 Kim Moir CLA 2007-05-25 18:04:35 EDT
Verified that Eclipse and Europa update sites appear in I20070525-1350 as usual.
Comment 24 Kim Moir CLA 2007-05-28 11:12:34 EDT
closing.