Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 188290 - Create WorkbenchDeploymentAdapter to extend JavaExecutionDeploymentAdapater
Summary: Create WorkbenchDeploymentAdapter to extend JavaExecutionDeploymentAdapater
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact:
URL:
Whiteboard: closed471
Keywords:
Depends on: 165173
Blocks:
  Show dependency tree
 
Reported: 2007-05-22 08:44 EDT by Joe Toomey CLA
Modified: 2016-05-05 11:02 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Toomey CLA 2007-05-22 08:44:37 EDT
There is currently some logic in the ArtifactUtil class that has behavior specific to workbench based test types hardcoded based on the test types themselves.  This means if someone wanted to add another workbench based test type to TPTP, they would either have to modify our code, or re-implement a large chunk of our deployment code in their own deployment adapter.

The better thing to do is to slightly refactor the JavaExecutionDeploymentAdapter, and then extend it with a WorkbenchDeploymentAdapter.  This will require some refactoring to pass state all the way into ArtifactUtil, so we can't do this in 4.4.  But when we do this, we can remove the boolean workbenchMode in ArtifactUtil.calculateClasspath(), and the solution will be much more extensible.
Comment 1 Paul Slauenwhite CLA 2007-05-22 09:04:17 EDT
Please provide a sizing.
Comment 2 Paul Slauenwhite CLA 2009-06-30 06:57:02 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 3 Paul Slauenwhite CLA 2009-07-03 07:05:42 EDT
Closing.
Comment 4 Paul Slauenwhite CLA 2009-07-03 07:28:33 EDT
Mistakenly closed for the originator.  Reopening for the originator to verify/close.
Comment 5 Paul Slauenwhite CLA 2009-07-03 07:30:00 EDT
Re-resolving as WONTIFX.
Comment 6 Kathy Chan CLA 2010-11-18 18:56:34 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.