Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 188061 - org.eclipse.bpel.common.ui.composite.EditorReference can't be built on top of Eclipse 3.3
Summary: org.eclipse.bpel.common.ui.composite.EditorReference can't be built on top of...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BPEL (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Vitaly Tishkov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-21 06:20 EDT by Vitaly Tishkov CLA
Modified: 2022-10-03 11:11 EDT (History)
1 user (show)

See Also:

Attachments
a patch for the bug (1.29 KB, patch)
2007-05-21 06:21 EDT, Vitaly Tishkov CLA 		bbrodt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Tishkov CLA 2007-05-21 06:20:16 EDT 
Build ID: I20070222-0951

Steps To Reproduce:
3 new methods were introduced in org.eclipse.ui.IWorkbenchPartReference:
    - public String getPartProperty(String key);
    - public void addPartPropertyListener(IPropertyChangeListener listener);
    - public void removePartPropertyListener(IPropertyChangeListener listener);

See http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/IWorkbenchPartReference.java?revision=1.15&view=markup for more details.

org.eclipse.bpel.common.ui.composite.EditorReference doesn't have them
implemented. This causes compilation errors. 

Creating stubs for these methods will solve the problem.
Comment 1 Vitaly Tishkov CLA 2007-05-21 06:21:39 EDT 
Created attachment 67959 [details]
a patch for the bug
Comment 2 Rodrigo Peretti CLA 2007-05-22 09:28:33 EDT 
The classes under org.eclipse.bpel.ui.common.composite.* are part of a workaround (hack) for https://bugs.eclipse.org/bugs/show_bug.cgi?id=37719

I would recommend removing them from the BPEL editor code and in case the function is really needed ask for that Eclipse Platform feature above to be implemented.
Comment 3 Rodrigo Peretti CLA 2007-05-22 10:45:42 EDT 
Another related bug:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=46207
Comment 4 Michal Chmielewski CLA 2007-05-22 12:30:21 EDT 
This may be easier said then done ... 

The "embedded" editor framework depends on these hacks ...

And we have continued to use that concept. And it looks that in reading all these bugs, this is one issue that is not going to get fixed any time soon ... well ... it will not be looked again until 4.0

Any other ideas besides the status quo ?
Comment 5 Rodrigo Peretti CLA 2007-05-22 14:42:57 EDT 
I understand it is tough. The Eclipse editor framework gives a lot of functionality which is very nice to reuse and you wouldn't want to rewrite all of that.

The ideal solution is to push for those features to be implemented by Eclipse and the only alternative I can see is maintaining the current code. Implementing the stubs that Vitaly mentioned might help but that is not the ideal path since they make use of internal Eclipse classes which can change without notice (not just API changes but behavior as well).
Comment 6 Michal Chmielewski CLA 2007-05-31 19:28:02 EDT 
Since you provided the fix, I'll take looksie and check it in. Based on the comments from Rodrigo we are between a rock and hard place on this one.
Comment 7 Michal Chmielewski CLA 2007-06-22 18:10:30 EDT 
I had to make that change to allow for Europa usage ... and I hear you are on vacation until 24 of June.
Comment 8 Robert Brodt CLA 2012-04-18 14:15:49 EDT 
Comment on attachment 67959 [details]
a patch for the bug

Updated iplog flag for v1.0 release review.