Comment 1 Mik Kersten 2007-05-17 21:01:17 EDT

Rob: this might already be in the Pending Changes of the porting guide.

Comment 2 Robert Elves 2007-05-18 12:07:48 EDT

Yes it is in the pending changes. I'll rename this report to track those changes...

http://wiki.eclipse.org/index.php/Mylar_Porting_Guide#Pending_Changes

Comment 3 Steffen Pingel 2007-05-30 00:25:27 EDT

Rob, there is a little bit of a naming inconsistency in the current task data API:

 RepositoryTaskData
 TaskComment
 RepositoryAttachment

And I guess the new type hierarchy will get rid of the Repository prefix all together? While I have always found the prefix superfluous it is used in many places and it would be confusing to remove it everywhere now.

 ITask
  Task
   TracTask
 
 So given this is correct I propose to rename RepositoryAttachment to TaskAttachment.
 

Comment 4 Eugene Kuleshov 2007-05-30 01:53:47 EDT

BTW, do we really need ITask interface?

Comment 5 Mik Kersten 2007-05-30 07:56:24 EDT

Not necessarily.  Rob and I will do a full pass through the naming of public types once the key API work is done (e.g. offline storage).

Comment 6 Steffen Pingel 2007-06-13 20:23:32 EDT

We have three different terms for synchronization that should be unified to one consistent term. The verbose version "synchronize" would be my preference and is used most of the time:

 * AbstractTask.isSynchronizing()  (which is also inconsistent with setCurrentlySynchronizing())
 
 * AbstractTask.getSyncState()
 
 * I have also seen synch...() but can't find a good reference right now


 

Comment 7 Steffen Pingel 2007-06-13 20:30:35 EDT

Found it... ScheduledTaskListSynchJob

Comment 8 Mik Kersten 2007-06-14 01:57:35 EDT

Some of mine (also need to add AbstracTask architecture diagram)

ITaskListChangeListener: new delta mechanism

TaskList.notifyContainerUpdated -> notifyContainersUpdated

ITaskListElement -> AbstractTaskListElement
AbstractTaskContainer -> AbstractTaskListElement
AbstractRepositoryTaskEditor -> AbstractTaskEditor
AbstractRepositoryTask -> AbstractTask
IMylarStatusConstants and MylarStatus: merged with RepositoryStatus
TaskListPreferenceConstants -> TasksUiPreferenceConstants
MylarIdePlugin -> FocusedIdePlugin
MylarJavaPlugin -> JavaUiBridgePlugin
MylarReportsPlugin -> MonitorReportsPlugin
MylarResourcesPlugin -> FocusedResourcesPlugin

Comment 9 Mik Kersten 2007-06-14 14:40:28 EDT

TaskList.moveToRoot(..): removed, use moveToContainer(..) instead
TaskList.removeFromRoot(..): removed
TaskList.getRootTasks(): removed, use default category
AbstractTaskEditor -> AbstractRepositoryTaskeditor

Comment 10 Mik Kersten 2007-06-14 14:42:52 EDT

AbstractTaskEditorInput -> AbstractRepositoryTaskEditorInput

Comment 11 Robert Elves 2007-06-14 17:30:12 EDT

New synchronization api needs to be on porting guide (and javadoc reviewed).

Comment 12 Mik Kersten 2007-06-15 18:08:18 EDT

MylarStatusManager -> StatusManager (moved to mylyn.monitor.core)

Comment 13 Mik Kersten 2007-06-15 20:59:23 EDT

AbstractRepositoryUrl.getActivityUrl() -> getHistoryUrl()

Comment 14 Mik Kersten 2007-06-18 22:59:49 EDT

ITaskEditorFactory -> AbstractTaskEditorFactory

Comment 15 Steffen Pingel 2007-06-19 22:17:51 EDT

AbstractTask.RepositoryTaskSyncState seems a bit long. I suggest to rename the enum to SyncState.

Comment 16 Mik Kersten 2007-06-20 00:50:49 EDT

Agreed.  I have outgoing changes and can't rename it.  

Rob: please consider renaming it to SynchronizationState, or let's make sure that we are consistent in synch vs. sync.

Comment 17 Steffen Pingel 2007-06-20 03:50:15 EDT

TaskRepositoryManager.notifyRepositorySettingsChagned() is mispelled.

Comment 18 Mik Kersten 2007-06-21 04:04:31 EDT

externalizers replace by AbstractTaskListFactory architecture (still need to update extension point)

Comment 19 Robert Elves 2007-06-23 01:51:23 EDT

Done. Porting guide updated.