Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 186977 - [EditorMgmt] Editor input factories should not return editor input if input has been deleted
Summary: [EditorMgmt] Editor input factories should not return editor input if input h...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 258456 349543 356474 366122 (view as bug list)
Depends on: 209497
Blocks:
  Show dependency tree
 
Reported: 2007-05-15 06:47 EDT by Dani Megert CLA
Modified: 2019-11-14 03:18 EST (History)
4 users (show)

See Also:


Attachments
Screenshot of the error (71.70 KB, image/png)
2011-12-09 04:57 EST, Alessio Pollero CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-05-15 06:47:28 EDT
I20070515-0010.

Editor input factories should not return an editor input if the element denoted by the input has been deleted. Currently they return the editor input and pass it to the editor. This causes unnecessary work (could even load the corresponding editor plug-in) as the editor cannot display that input anyway.

NOTE: for resources file.exists() check won't always do the trick as the file might still exist in the workspace with file.isSynchronized(...) == false.

Affected factories in Platform UI are:
- FileEditorInputFactory
- FileStoreEditorInputFactory
Comment 1 Boris Bokowski CLA 2008-05-02 14:56:42 EDT
Mass update - removing 3.4 target. This was one of the bugs I marked for investigation (and potential fixing) in 3.4 but I ran out of time. Please ping on the bug if fixing it would be really important for 3.4, and does not require API changes or feature work.
Comment 2 Dani Megert CLA 2008-12-13 06:32:34 EST
*** Bug 258456 has been marked as a duplicate of this bug. ***
Comment 3 Boris Bokowski CLA 2009-11-17 13:02:35 EST
Remy is now responsible for watching the [EditorMgmt] component area.
Comment 4 Dani Megert CLA 2011-09-01 09:50:18 EDT
*** Bug 356474 has been marked as a duplicate of this bug. ***
Comment 5 Dani Megert CLA 2011-12-09 04:53:12 EST
*** Bug 349543 has been marked as a duplicate of this bug. ***
Comment 6 Dani Megert CLA 2011-12-09 04:53:19 EST
*** Bug 366122 has been marked as a duplicate of this bug. ***
Comment 7 Alessio Pollero CLA 2011-12-09 04:57:26 EST
Created attachment 208154 [details]
Screenshot of the error

The error happens also if you open Eclipse and some files of a project A are opened in the editors, then if you remove the project A you will get the error in the screenshot.
Comment 8 Dani Megert CLA 2011-12-09 05:07:29 EST
(In reply to comment #7)
> Created attachment 208154 [details]
> Screenshot of the error
> 
> The error happens also if you open Eclipse and some files of a project A are
> opened in the editors, then if you remove the project A you will get the error
> in the screenshot.
I cannot reproduce that. Could you provide more details steps based on a new workspace and using
http://download.eclipse.org/eclipse/downloads/drops/R-3.7.1-201109091335/index.php

Also, please put your comments in your bug as this bug here is only about not yet materialized editors.
Comment 9 Dani Megert CLA 2011-12-14 05:31:08 EST
(In reply to comment #7)
> Created attachment 208154 [details]
> Screenshot of the error
> 
> The error happens also if you open Eclipse and some files of a project A are
> opened in the editors, then if you remove the project A you will get the error
> in the screenshot.

Yes, but only if the editor which the workbench tries to activate after (auto-) closing the current one, is on a file from the deleted project. And this what this bug here covers.
Comment 10 Lars Vogel CLA 2019-11-14 03:18:09 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.