Community
Participate
Working Groups
Both ssh.files and ssh.shells advertise themselves for _sftp-ssh._tcp serviceType. Create New connection of type discovery, enable multicast address, let it detect two RHEL5 hosts which advertise _sftp-ssh._tcp. Only the "Files" subsystem is shown for these in the Wizard. Should it also show the "Shells" subsystem? Or am I missing the meaning of this dialog and it should just show that "somethign" can be connected?
For sftp and ssh, 2 different services should be advertised: sftp-ssh Secure File Transfer Protocol over SSH (_sftp-ssh._tcp) ssh SSH Remote Login Protocol (_ssh._tcp) A part of this, I can see some issues when more than one plugin can be applied to an advertised service (ie you have 2 different telnet clients), so possibly we could add a disambiguation page in the discovery wizard.
Well it looks like the real world (i.e. RHEL5) advertises ssh-sftp only meaning both Shell-like and File-like services over ssh. I have thus changed the plugin.xml for org.eclipse.rse.subsystems.shells.ssh to advertise the SSH Shell subsystem for both: "_ssh._tcp;_ssh-sftp._tcp" This works fine for me, the detected Redhat host is created by discovery now with both a files and a shells subsystem, and both work fine. I'm fine with this behavior; it could be slightly polished by showing both the files and the shells subsystem in the discovery wizard, if both match the advertised service descriptor.
It works because the current behaviour tries to create one service per each matching plugin, so if you have 2 plugins expecting _sftp-ssh._tcp (sftp and ssh), both will be created. If it works for you it's fine, but I'd be nice adding a disambiguation-preview page in the future. There could be also problems if the subsystems are of the same kind, as per bug 174495.
Won't fix this since discovery is being archived.
