Community
Participate
Working Groups
A JIRA server sends the repository location as a redirect on login. This location should be used as the repository URL in the properties dialog when the connection is validated.
- do not follow redirect to http from https without warning
While implementing this I could not quite figure out what the best user interaction when validating a repository that redirects to another location (e.g. https:// instead of http://): 1) show a selection dialog displaying alternative locations ("Keep my location", "Use redirect location") 2) replace url in dialog and display a warning [current implementation]
Created attachment 78513 [details] mylyn/context/zip
Created attachment 78518 [details] location dialog I have implemented a dialog that prompts the user if the repository location does not match (see attached snap shot). We can iterate for the next release how to improve the interaction. I have also changed the logging of login errors to only be active when the repository is being validated to avoid polluting the Eclipse error log.
Created attachment 78519 [details] mylyn/context/zip
I have changed the wording to "Keep current location:". We should consider making this part of the repository settings API. Bugzilla displays a modal error dialog when attempting to validate http://bugs.eclipse.org/bugs instead of following the redirect to https://... Marking as resolved.
It is somehow weird to have those radio buttons. Maybe we could rework dialog to show urls in the message, but use buttons for taking particular actions, like update, ignore and cancel.
There could be potentially three urls: - the user provided one - the one returned by getServerInfo().getBaseURL() - the one the redirects during web login pointed to We could replace the radio buttons by a combo box. Another idea I had was to add them to the combo box in the repository settings dialog but I'd rather prioritize other bugs and push this to the next release.
+1 for the prioritization suggested in comment#8. I actually prefer the radio buttons to a combo box because they show the entire text for both options. Fyi in Vista this kind of UI is standard and I find it works very well. But instead of Radios they make large hyperlink-style buttons with text that you can click, reducing the click count from 2 to 1.
Mik, for the sake of God, please don't add hyperlinks for stuff like that. Double-clickable radio buttons are old ui trick that been probably used since NT times...
No plans to do so, iwas just pointing out some similarity with something that is working well in the Vista UI. Btw, visually they really look like hyperlinks, just act a bit like them (e.g. parts of text underline on hover).
